python2Packages: nuke down to 4 packages#479971
Merged
SigmaSquadron merged 25 commits intoNixOS:masterfrom Jan 15, 2026
Merged
Conversation
This was referenced Jan 14, 2026
5a8b52d to
d77c3c1
Compare
doronbehar
reviewed
Jan 14, 2026
cf1bf07 to
51d9fe9
Compare
doronbehar
approved these changes
Jan 14, 2026
Contributor
doronbehar
left a comment
There was a problem hiding this comment.
Changes LGTM, but I think it'd be nice at this point to get a 2nd pair of eyes on this.
gepbird
reviewed
Jan 14, 2026
Contributor
|
There's a typo in e524b93's commit message |
51d9fe9 to
d9e4a79
Compare
gepbird
approved these changes
Jan 15, 2026
Contributor
gepbird
left a comment
There was a problem hiding this comment.
Thanks!
Diff looks good.
Contributor
|
gah, sorry. Misclicked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we removed gimp2 python3 support, many of the dependencies are no longer needed.
resholvealso embark its own dependencies, so almost every packages can be removed.Only
setuptoolsis remaining, and it usespip,bootstrap-pip,wheel. Removing any of theses 4 packages will cause an infinite recursion while trying to buildresholve.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.