musescore-evolution: init at 3.7.0 #478650
Conversation
|
|
||
| stdenv.mkDerivation (finalAttrs: { | ||
| pname = "musescore-evolution"; | ||
| version = "3.7.0"; |
There was a problem hiding this comment.
I cannot see 3.7.0 tag in upstream repo. a better version number might be 3.6.2-unstable-20260110
There was a problem hiding this comment.
Well there are no releases on github, but it is named 3.7 to set it apart from the official 3.6.2. Is there something else that would work better? Could we do 3.7.0-unstable-20260110 or something like that?
There was a problem hiding this comment.
Alright I updated the version name to that. Let me know if anything else needs work!
|
This package is very useful to me because of missing feature in musescore4. Where does the name evolution come from? The github project doesn't name itself evolution |
Yeah it can be a little hard to find since the repo has the same name as the upstream fork, but on the bottom of the repo it has that name and same as at this wiki: https://github.com/Jojo-Schmitz/MuseScore/wiki |
|
This package would need to be updated often. Could we add an update script to do it automatically? |
Yeah that sounds like a good idea. I'm not exactly sure how to do that though. Are there any resources or specific techniques I can learn to do that? |
Some packages in nixpkgs defined them. passthru.updateScript |
|
Alright I added an auto update script and used it on the package using |
|
|
doesn't build on macos |
|
|
Alright I disabled precompiled headers for macOS which looks promising based on the OfBorg logs. I don't own a mac so I don't know if it actually functions but it builds now. |
|
|
remove "-DCMAKE_DISABLE_PRECOMPILE_HEADERS=ON" add this patch https://github.com/mio-19/nurpkgs/blob/main/pkgs/musescore-evolution/musescore-evolution-pch-fix.patch now error is on install stage |
|
I added cmake patch to https://github.com/mio-19/nurpkgs/blob/main/pkgs/musescore-evolution/musescore-evolution-pch-fix.patch now it builds on macos diff --git a/main/CMakeLists.txt b/main/CMakeLists.txt
index e67e5c8f5c..a4c6dd61fd 100644
--- a/main/CMakeLists.txt
+++ b/main/CMakeLists.txt
@@ -499,15 +499,6 @@ if (APPLE)
../fonts/finalebroadway/FinaleBroadwayText.otf
DESTINATION ${Mscore_SHARE_NAME}${Mscore_INSTALL_NAME}fonts
)
- install(DIRECTORY
- ${QT_INSTALL_QML}
- DESTINATION ${Mscore_SHARE_NAME}${Mscore_INSTALL_NAME}
- REGEX ".*QtWebkit.*" EXCLUDE
- REGEX ".*QtTest.*" EXCLUDE
- REGEX ".*QtSensors.*" EXCLUDE
- REGEX ".*QtMultimedia.*" EXCLUDE
- REGEX ".*QtAudioEngine.*" EXCLUDE
- REGEX ".*_debug\\.dylib" EXCLUDE)
endif (APPLE)
if (MSCORE_OUTPUT_NAME) |
|
nix run works on macos. I can see gui working |
|
Nice work! Does audio and everything else seem normal? |
|
I can open guitar pro file and audio works after two changes:
diff --git a/mscore/qml/msqmlengine.cpp b/mscore/qml/msqmlengine.cpp
index 77c94b593c..ffd066d41d 100644
--- a/mscore/qml/msqmlengine.cpp
+++ b/mscore/qml/msqmlengine.cpp
@@ -37,9 +37,9 @@ MsQmlEngine::MsQmlEngine(QObject* parent)
setImportPathList(importPaths);
#endif
#ifdef Q_OS_MAC
- QStringList importPaths;
+ QStringList importPaths = importPathList();
QDir dir(mscoreGlobalShare + QString("/qml"));
- importPaths.append(dir.absolutePath());
+ importPaths.prepend(dir.absolutePath());
setImportPathList(importPaths);
#endif
}
|
This comment was marked as outdated.
This comment was marked as outdated.
|
No. qtWrapperArgs change is not needed and maybe not correct. see latest patch at https://github.com/mio-19/nurpkgs/blob/main/pkgs/musescore-evolution/musescore-evolution-pch-fix.patch |
Feel free to add a commit if you want. Appreciate the help with Mac. |
this commit mio-19@1316d6a |
|
please squash to one commit and force push |
All commits? |
|
one maintainer list commit; one musescore-evolution init commit |
|
@nemeott merge conflict |
|
@nemeott There shouldn't be a merge commit (3rd commit), you should rebase your initial 2 commits onto master instead. Otherwise CI linting fails: https://github.com/NixOS/nixpkgs/actions/runs/21934108959/job/63344530372?pr=478650 |
I'm confused on how to do that. I tried just updating my version of maintainers manually to fix the merge conflict but now am getting another issue. |
Musescore Evolution is an unoffical fork of musescore 3.6.2, which provides extra patches, fixes, features. One notable feature is the ability to import files saved in Musescore 4.X versions. There are also a few other backported features.
|
@nemeott I forgot to review updateScript. It isn't working as expected |
Right, that's because it assumes the update script is being run by the |
Added package for Musescore Evolution, an unoffical fork of MuseScore 3.6.2. It provides extra patches, fixes, features. One notable feature is the ability to import files saved in Musescore 4.X versions. There are also a few other back-ported features. It's pretty much a better version of 3.6.2, which many people still use.
Also added myself to the maintainers list.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.