haskell.compiler.ghc966DebianBinary: fix evaling pname#478128
haskell.compiler.ghc966DebianBinary: fix evaling pname#478128wolfgangwalther merged 1 commit intoNixOS:masterfrom
Conversation
|
(Inviting myself ig, since CI didn't want to request my review) Could prolly be written so |
CI will never request a review for you, because changes to this derivation won't cause any rebuilds on the 4 platforms eval'd in CI. It does ping the haskell team members via codeowners. To receive maintainer pings, you should probably add a codeowner entry for this file for you instead. |
wolfgangwalther
left a comment
There was a problem hiding this comment.
LGTM in principle, but let's remove the now unused variantSuffix, too.
Oki: #478378 Also noticing that this doesn't build anymore, because Debian finally bumped their GHC to 9.10.3, and debian-ports doesn't seem to retain any old versions on there… Will add a backup src for now, and make a PR to bump to the new version when my hardware is free again. |
pname needs to always be evaluable so that our package index can be correctly generatedw
pname needs to always be evaluable so that our package index can be correctly generatedw
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.