Skip to content

update-from-overlay.py: A cleaner bulk-update script#473079

Merged
jian-lin merged 1 commit intoNixOS:masterfrom
museoa:update-from-overlay.py
Mar 3, 2026
Merged

update-from-overlay.py: A cleaner bulk-update script#473079
jian-lin merged 1 commit intoNixOS:masterfrom
museoa:update-from-overlay.py

Conversation

@AndersonTorres
Copy link
Copy Markdown
Member

@AndersonTorres AndersonTorres commented Dec 21, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: emacs Text editor labels Dec 21, 2025
jian-lin
jian-lin requested changes Dec 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@jian-lin jian-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An important part of bumping elisp pkgs is to find new failed builds and fix them or report them to upstreams, which this PR seems not include.

I think it is a good idea to focus on one thing in a PR. Let's discuss your python rewrite here and do the elisp bump in another PR. I'll do the bump if nobody does it first.

jian-lin
jian-lin reviewed Dec 23, 2025
View reviewed changes
jian-lin
jian-lin requested changes Dec 23, 2025
View reviewed changes
jian-lin
jian-lin requested changes Dec 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@jian-lin jian-lin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is very useful and easy to add, so I'll mark it as blocking.

@AndersonTorres
Copy link
Copy Markdown
Member Author

AndersonTorres commented Dec 23, 2025

An important part of bumping elisp pkgs is to find new failed builds and fix them or report them to upstreams, which this PR seems not include.

The bumping here is a proof of concept, not intended to be merged.

@AndersonTorres AndersonTorres force-pushed the update-from-overlay.py branch 2 times, most recently from fa6b143 to 3b66fb3 Compare December 24, 2025 21:42
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 25, 2025
@jian-lin
Copy link
Copy Markdown
Contributor

jian-lin commented Dec 25, 2025

It seems this PR is under active development. I'll unsubscribe it. Feel free to ping me when it is ready for review.

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 26, 2025
@AndersonTorres
Copy link
Copy Markdown
Member Author

AndersonTorres commented Dec 26, 2025 •
edited
Loading

@jian-lin now that I wrote the docstrings, feel free to review.

(edit: I have added a commit, adding a logging hierarchy.)

@AndersonTorres AndersonTorres force-pushed the update-from-overlay.py branch 2 times, most recently from 1517ca0 to 1216617 Compare December 27, 2025 23:19
@jian-lin jian-lin self-requested a review December 30, 2025 12:20
@AndersonTorres AndersonTorres force-pushed the update-from-overlay.py branch from 1216617 to e051229 Compare January 5, 2026 14:48
@AndersonTorres AndersonTorres mentioned this pull request Jan 9, 2026
Merged
13 tasks
jian-lin
jian-lin requested changes Jan 19, 2026
View reviewed changes
@AndersonTorres AndersonTorres force-pushed the update-from-overlay.py branch 2 times, most recently from 0b8cdfb to c336a91 Compare January 23, 2026 16:00
@AndersonTorres
Copy link
Copy Markdown
Member Author

AndersonTorres commented Jan 23, 2026 •
edited
Loading

@jian-lin
For the case when you review the code again, I get rid of pygit2 dependency. It is way cheaper to just use Git program.

Further I have rearranged the code to not rely on global structures. It was surprisingly cleaner than I expected!

@AndersonTorres AndersonTorres force-pushed the update-from-overlay.py branch 6 times, most recently from 8ce1a2e to 15bf1a3 Compare January 27, 2026 19:24
@nixpkgs-ci nixpkgs-ci bot requested a review from a team February 9, 2026 11:57
@AndersonTorres AndersonTorres marked this pull request as draft February 11, 2026 11:33
@AndersonTorres AndersonTorres marked this pull request as ready for review February 11, 2026 12:32
@AndersonTorres
Copy link
Copy Markdown
Member Author

AndersonTorres commented Feb 12, 2026 •
edited
Loading

Now the logfile is "split":
- Screen shows info messages
- Logfile shows debug and info messages
Not needed. Just use redirection if you like :)

@AndersonTorres AndersonTorres force-pushed the update-from-overlay.py branch 2 times, most recently from 3f41618 to b5c3601 Compare February 20, 2026 18:11
@AndersonTorres AndersonTorres mentioned this pull request Feb 22, 2026
Closed
13 tasks
jian-lin
jian-lin requested changes Feb 26, 2026
View reviewed changes
emacs: Add update-from-overlay.py
a96110f 
This is a new script written in Python 3 that fetches, checks and commits the
elisp package sets from nix-community/emacs-overlay.
jian-lin
jian-lin approved these changes Mar 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jian-lin jian-lin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script works and #494565 is created by it. So I plan to merge it.

I also left a few suggestions. I am willing to improve the script according to those suggestions if you are not, after the merge.

pkgs/applications/editors/emacs/elisp-packages/update-from-overlay.py
'''
logger.debug('BEGIN')

location = emacs_overlay.elisp_packages_set[name]['location']
Copy link
Copy Markdown
Contributor

@jian-lin jian-lin Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about replacing the emacs_overlay function argument with emacs_overlay.elisp_packages_set[name] since we only need emacs_overlay.elisp_packages_set[name] in this function?

This applies to many other places.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 2, 2026
@jian-lin jian-lin added this pull request to the merge queue Mar 3, 2026
Merged via the queue into NixOS:master with commit 0aea451 Mar 3, 2026
32 of 34 checks passed
@jian-lin jian-lin mentioned this pull request Mar 3, 2026
Merged
13 tasks
@AndersonTorres AndersonTorres deleted the update-from-overlay.py branch March 5, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jian-lin jian-lin jian-lin approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

@panchoh panchoh Awaiting requested review from panchoh

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees

No one assigned

Labels

6.topic: emacs Text editor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndersonTorres @jian-lin