eiskaltdcpp: fix build by adding minimum version policy to cmakeFlags#471534
Merged
Sigmanificient merged 2 commits intoNixOS:masterfrom Mar 23, 2026
Merged
eiskaltdcpp: fix build by adding minimum version policy to cmakeFlags#471534Sigmanificient merged 2 commits intoNixOS:masterfrom
Sigmanificient merged 2 commits intoNixOS:masterfrom
Conversation
0c5dd20 to
7d4f3e4
Compare
Contributor
Author
|
Sigmanificient
requested changes
Dec 31, 2025
Member
There was a problem hiding this comment.
Setting minimum version policy to cmakeFlags is a last resort technique with should avoid if possible. Please follow the step from the tracking and look into shipping the patch upstream.
- part of #445447
17 tasks
fix EiskaltDC++ compilation from nixpkgs by adding -DCMAKE_POLICY_VERSION_MINIMUM=3.5
7d4f3e4 to
63af1fa
Compare
Sigmanificient
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix EiskaltDC++ compilation from nixpkgs by adding -DCMAKE_POLICY_VERSION_MINIMUM=3.5
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.