pnpm.fetchDeps: output a tarball from fetcherVersion 3#469950
Merged
Scrumplex merged 3 commits intoNixOS:masterfrom Dec 15, 2025
Merged
pnpm.fetchDeps: output a tarball from fetcherVersion 3#469950Scrumplex merged 3 commits intoNixOS:masterfrom
Scrumplex merged 3 commits intoNixOS:masterfrom
Conversation
588ae21 to
b27dd06
Compare
13 tasks
b27dd06 to
2fddbd1
Compare
Scrumplex
reviewed
Dec 11, 2025
4f17f2f to
8b6ac04
Compare
doronbehar
reviewed
Dec 12, 2025
e9aabb1 to
c2c50f4
Compare
doronbehar
approved these changes
Dec 14, 2025
Contributor
doronbehar
left a comment
There was a problem hiding this comment.
Thanks for ordering the commits :). Should be good to go unless you would like to incorporate the Nit suggestions.
c2c50f4 to
a3ac7f4
Compare
doronbehar
reviewed
Dec 14, 2025
Contributor
Author
|
No new failures. I also rebuild a few pnpm deps with fetcher versions 1, 2 and 3.
|
Scrumplex
approved these changes
Dec 15, 2025
Contributor
|
Successfully created backport PR for |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #376299 (comment).
This reduced
bash-language-server.pnpmDepsfrom 118M to 21M.If we want to do a treewide version update, it should be in a separate PR.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.