busybox: add tests#467609
Merged
Merged
Conversation
13 tasks
18d352f to
b0086e1
Compare
Adds the upstream test suite as passthru.tests.withCheck. We have to fix up some tests due to our constraints (no FHS, no internet), and some tests are too hard to fix and are disabled for now.
b0086e1 to
5f1357f
Compare
Contributor
|
Ran this by cherry-picking the change in #515158, and So, nominally, this builds... and Seems to actually have ran the test suite, and having only PASSes. |
samueldr-at-cyberus
approved these changes
May 1, 2026
samueldr-at-cyberus
left a comment
Contributor
There was a problem hiding this comment.
On the whole, approving, even with the review comment.
| export CONFIG_UNICODE_USING_LOCALE=y | ||
|
|
||
| # DISABLE SOME TESTS | ||
| # TODO(balsoft): fix the tests instead of skipping |
Contributor
There was a problem hiding this comment.
TODO when? It this going to be tracked once this PR is merged?
(Sorry, stock review comment when I see a TODO or similar comments :))
Member
Author
There was a problem hiding this comment.
Yeah, good call. I'll make an issue about it to track progress. I hope to get back to this within this year :)
Contributor
There was a problem hiding this comment.
Just checking in, no issue was made or cross-referenced this :)
No worries if you have got it stashed somewhere else otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the upstream test suite as passthru.tests.withCheck.
We have to fix up some tests due to our constraints (no FHS, no internet), and some tests are too hard to fix and are disabled for now.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.