Merged
Conversation
Fixed minor issue where kube-addon manager complaints about /opt/namespace.yaml missing. Added release notes with reference to Kubernetes 1.11 release notes. closes NixOS#43882
|
Success on aarch64-linux (full log) Attempted: kubernetes Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: kubernetes Partial log (click to expand)
|
Contributor
Author
|
@GrahamcOfBorg test kubernetes.rbac.singlenode kubernetes.dns.singlenode kubernetes.rbac.multinode kubernetes.dns.multinode |
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: tests.kubernetes.rbac.singlenode, tests.kubernetes.dns.singlenode, tests.kubernetes.rbac.multinode, tests.kubernetes.dns.multinode Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: tests.kubernetes.rbac.singlenode, tests.kubernetes.dns.singlenode, tests.kubernetes.rbac.multinode, tests.kubernetes.dns.multinode Partial log (click to expand)
|
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since #45670 will not make it to 18.09, I'm PR'ing the kubernetes package separately. I'd like it if this could be backported to NixOS 18.09.
Even though this PR has no module updates, the main purpose of issue #43882 was to upgrade to v1.11, thus:
closes #43882
@srhb ping
Things done
NixOS tests for rbac and dns runs clean.
I've also tested this with a three node cluster in Google Cloud and it turns out that the existing kubernetes module works seamlessly with the 1.11.3 package, although some of the k8s components yield warnings for deprecated flags.
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)