systemd: specify default-user-shell#458591
Conversation
There was a problem hiding this comment.
Incidentally, I was experimenting with exactly this a couple of weeks ago and discovered the need for the exact same fix. So I've already tested this weeks ago and found it good :P Forgot to open a PR though. Thanks!
Probably still need to run relevant NixOS tests though. I'll do that soon.
|
|
|
It's failing to run nixfmt due to a hash mismatch?
The code is definitely properly formatted because the check passed for the PR. Not sure what to do here... |
|
Re-running CI due to a since-fixed unrelated treefmt-nix failure |
|
@mdaniels5757 Looks like it's still broken 😕 |
|
Hmm. It fixed itself on other PRs when re-running, though. Maybe let's try again??? |
|
OH, this targets staging. |
This option is used to specify the default shell used for homed users, among other things. By default it is set to `/bin/bash` which doesn't exist on NixOS. Setting this option makes `homectl create` work without having to specify `--shell /run/current-system/sw/bin/bash`.
d4fe9a6 to
21f767a
Compare
|
I did a force-push with the same commit contents, just a different timestamp to trigger the CI to run again. |
This option is used to specify the default shell used for homed users, among other things. By default it is set to
/bin/bashwhich doesn't exist on NixOS.Setting this option makes
homectl creatework without having to specify--shell /run/current-system/sw/bin/bash.(I'm currently building the NixOS tests but it will take a while due to needing to rebuild the world in staging. I tested the change by setting
systemd.packageon unstable and it worked.)Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.