Skip to content

python3Packages.uv-build: decouple from uv#457247

Merged
GaetanLepage merged 3 commits into
NixOS:stagingfrom
bengsparks:uv-split
Nov 3, 2025
Merged

python3Packages.uv-build: decouple from uv#457247
GaetanLepage merged 3 commits into
NixOS:stagingfrom
bengsparks:uv-split

Conversation

@bengsparks

@bengsparks bengsparks commented Oct 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Only 1k / 10k rebuilds come solely from home-assistant's dependency on uv.

The remainder likely stems from python3Packages.cryptography's transitive dependency on
python3Packages.uv-build via python3Packages.cryptography-vector's build-system.

The remaining occurrences in the file are in passthru.tests and meta.{changelog,license},
so nothing that would influence rebuilds.

CC @mweinelt

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@bengsparks bengsparks mentioned this pull request Oct 31, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: python Python is a high-level, general-purpose programming language. labels Oct 31, 2025
@bengsparks

bengsparks commented Oct 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I am a little surprised to see this PR causing rebuilds. Is it because uv builds all of the workspace, whereas uv-build uses buildAndTestSubdir = "crates/uv-build";, but had previously inherited its cargoDeps value from uv?

EDIT: that can't be it, because uv's cargoHash value currently matches that of uv-build's cargoDeps.hash value.
I guess it stems from environment variable names in uv-build changing?

@bengsparks bengsparks changed the title python3Packages.uv-build: decouple from python3Packages.uv python3Packages.uv-build: decouple from uv Oct 31, 2025
@mweinelt

mweinelt commented Oct 31, 2025

Copy link
Copy Markdown
Member

Only 1k / 10k rebuilds come from the home-assistant dependency.

I would argue home-assistant rebuilds are also due to cryptography. It is basically very tightly integrated in the package set and rebuilds half of all python packages.

@bengsparks

bengsparks commented Oct 31, 2025

Copy link
Copy Markdown
Contributor Author

Ah that's unfortunate. Still, splitting the package means we can start bumping uv on master again?
I'll amend the commit message.

@mweinelt

mweinelt commented Oct 31, 2025

Copy link
Copy Markdown
Member

That was the intent behind the idea to split.

@nix-owners nix-owners Bot requested a review from Prince213 October 31, 2025 19:11
GaetanLepage
GaetanLepage approved these changes Oct 31, 2025
View reviewed changes

@GaetanLepage GaetanLepage left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 31, 2025
Prince213
Prince213 approved these changes Nov 1, 2025
View reviewed changes

@Prince213 Prince213 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 1, 2025
@GaetanLepage GaetanLepage added this pull request to the merge queue Nov 3, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 3, 2025
@GaetanLepage

GaetanLepage commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

Can you try to rebase and force-push @bengsparks? The CI failed in the merge queue.

@bengsparks
python3Packages.uv-build: decouple from uv
e2f5240 
Only 1k / 10k rebuilds come solely from `home-assistant`'s dependency on `uv`.

The remainder likely stems from `python3Packages.cryptography`'s transitive dependency on
`python3Packages.uv-build` via `python3Packages.cryptography-vector`'s `build-system`.

The remaining occurrences in the file are in `passthru.tests` and `meta.{changelog,license}`,
so nothing that would influence rebuilds.
@bengsparks
python3Packages.uv-build: passthru.updateScript is unnecessary
ddb9796
@bengsparks
uv: update updateScript comment
379e4a5
@GaetanLepage GaetanLepage added this pull request to the merge queue Nov 3, 2025
Merged via the queue into NixOS:staging with commit e26c41f Nov 3, 2025
26 checks passed
@bengsparks bengsparks mentioned this pull request Nov 7, 2025
Merged
13 tasks
@bengsparks bengsparks deleted the uv-split branch November 7, 2025 21:32
@bengsparks bengsparks mentioned this pull request Nov 13, 2025
Merged
13 tasks
@Prince213 Prince213 mentioned this pull request Nov 21, 2025
Merged
13 tasks
@bengsparks bengsparks mentioned this pull request Nov 25, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Prince213 Prince213 Prince213 approved these changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@mweinelt mweinelt Awaiting requested review from mweinelt

@niklaskorz niklaskorz Awaiting requested review from niklaskorz

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bengsparks @mweinelt @GaetanLepage @Prince213