Closed
Conversation
17 tasks
Contributor
Author
|
Marking this as draft for now. If I have time to review the AI-generated code then I'll un-draft it. |
Member
|
@samestep hello, do you have time to continue this pr? Thx! |
Contributor
Author
|
@Sigmanificient unfortunately no, not in the foreseeable future; I don't have sufficient CMake knowledge to confidently review or rewrite this code. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
This does fix the build, but the
pkgs/by-name/cm/cmtk/export-library-dependencies.patchfile is AI-generated so I don't trust it (and I'm not a CMake expert so I can't review it myself).passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.