unixODBCDrivers.sqlite: fix build with gcc15#446335
Merged
Merged
Conversation
986ca47 to
8ee1525
Compare
- add patch from fedora fixing incompatible-pointer-types errors.
Fixes build failure with gcc15:
```
sqlite3odbc.c:4521:24: error: assignment to 'void (*)(void)'
from incompatible pointer type 'void (*)(char **)' [-Wincompatible-pointer-types]
4521 | s->rowfree = freerows;
| ^
sqlite3odbc.c:2185:1: note: 'freerows' declared here
2185 | freerows(char **rowp)
| ^~~~~~~~
sqlite3odbc.c: In function 'drvtableprivileges':
sqlite3odbc.c:6173:24: error: assignment to 'void (*)(void)'
from incompatible pointer type 'void (*)(char **)' [-Wincompatible-pointer-types]
6173 | s->rowfree = sqlite3_free_table;
| ^
In file included from sqlite3odbc.h:49,
from sqlite3odbc.c:25:
/nix/store/w3ibvzff0yrpg8abrl8n2fxn0d9fpfpc-sqlite-3.50.2-dev/include/sqlite3.h:3144:17:
note: 'sqlite3_free_table' declared here
3144 | SQLITE_API void sqlite3_free_table(char **result);
| ^~~~~~~~~~~~~~~~~~
sqlite3odbc.c: In function 'drvprimarykeys':
sqlite3odbc.c:6593:16: error: assignment to 'void (*)(void)' from
incompatible pointer type 'void (*)(char **)' [-Wincompatible-pointer-types]
6593 | s->rowfree = freerows;
| ^
```
8ee1525 to
91b2fd8
Compare
Contributor
Author
|
Push to fix merge conflict. |
fabianhjr
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes build failure with gcc15:
Tested build with:
nix-build --expr 'with import ./. {}; unixODBCDrivers.sqlite.override { stdenv = gcc15Stdenv; }'Part of fixes for gcc15 update:
#440456
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.