Bring back functionTo to prevent evalutation errors while merging#44626
Closed
basvandijk wants to merge 3 commits intoNixOS:masterfrom
Closed
Bring back functionTo to prevent evalutation errors while merging#44626basvandijk wants to merge 3 commits intoNixOS:masterfrom
basvandijk wants to merge 3 commits intoNixOS:masterfrom
Conversation
This reverts commit 4ff1ab5. We need this to type options like: services.xserver.windowManager.xmonad.extraPackages that specify functions that take an attribute set containing packages / plugins and return a list containing a selection of the values in this set. The reason we need a dedicated type for this is to have the correct merge behaviour. Without the functionTo type merging multiple function option definitions results in an evaluation error. The functionTo type merges definitions by returning a new function that applies the functions of all the definitions to the given input and merges the result.
Without this patch merging options like services.xserver.windowManager.xmonad.extraPackages results in the evaluation error: error: value is a list while a set was expected, at nixpkgs/lib/options.nix:77:23 With this patch we get the desired merging behaviour that just concatenates the resulting package lists.
9 tasks
Member
|
This alternative would be the last on the list of things to be added back. This was a mistake, and we have plenty of alternative before going back to such extreme. (see #44601 (comment)) Short answer: No! |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is an alternative for #44601 as suggested by @oxij .
This is used to type options like:
services.xserver.windowManager.xmonad.extraPackagesthat specify functions that take an attribute set containing packages / plugins and return a list containing a selection of the values in this set.The reason we need a dedicated type for this is to define the correct merge behaviour. Without the
functionTotype merging multiple function option definitions results in an evaluation error.The
functionTomerges definitions by returning a new function that applies the functions of all the definitions to the given input and merges the results.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)