onetbb: fix build with gcc15#446139
Merged
Merged
Conversation
- add patch from merged upstream PR: https://www.github.com/uxlfoundation/oneTBB/pull/1831 uxlfoundation/oneTBB@712ad98 Fixes build failure with gcc15: ``` FAILED: [code=1] test/CMakeFiles/test_concurrent_unordered_map.dir/tbb/test_concurrent_unordered_map.cpp.o ... /nix/store/rd8c9w16nwys8yz1a9j2g2nhjn07464r-gcc-15.2.0/include/c++/15.2.0/bits/new_allocator.h:198:11: error: array subscript 2 is outside array bounds of 'StaticSharedCountingAllocator<std::allocator<tbb::detail::d2::list_node<long unsigned int> > >::value_type [1]' {aka 'tbb::detail::d2::list_node<long unsigned int> [1]'} [-Werror=array-bounds=] 198 | { __p->~_Up(); } | ^~~ compilation terminated due to -Wfatal-errors. cc1plus: all warnings being treated as errors ... FAILED: [code=1] test/CMakeFiles/test_concurrent_unordered_set.dir/tbb/test_concurrent_unordered_set.cpp.o ... /build/source/src/tbb/../../include/tbb/../oneapi/tbb/detail/_concurrent_unordered_base.h:172:20: error: array subscript 'tbb::detail::d2::value_node<AllocatorAwareData<std::scoped_allocator_adaptor<std::allocator<int> > >, long unsigned int>[0]' is partly outside array bounds of 'unsigned char [16]' [-Werror=array-bounds=] 172 | ~value_node() {} | ^ compilation terminated due to -Wfatal-errors. cc1plus: all warnings being treated as errors ```
silvanshade
approved these changes
Sep 25, 2025
Member
|
@NixOS/nixpkgs-merge-bot merge |
Contributor
|
@silvanshade merge not permitted (#305350): |
MatthewCroughan
approved these changes
Oct 11, 2025
MatthewCroughan
left a comment
Contributor
There was a problem hiding this comment.
onetbb doesn't cut releases very often so this makes sense
Contributor
|
@silvanshade wants to merge this PR. Requirements to merge this PR with
✔️ Enabled Auto Merge (#306934) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.github.com/uxlfoundation/oneTBB/pull/1831
uxlfoundation/oneTBB@712ad98
Fixes build failure with gcc15:
Tested build with:
nix-build --expr 'with import ./. {}; onetbb.override { stdenv = gcc15Stdenv; }'Part of fixes for gcc15 update:
#440456
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.