Skip to content

onetbb: fix build with gcc15#446139

Merged
nixpkgs-ci[bot] merged 1 commit into
NixOS:stagingfrom
ghpzin:pr-onetbb-gcc15
Nov 5, 2025
Merged

onetbb: fix build with gcc15#446139
nixpkgs-ci[bot] merged 1 commit into
NixOS:stagingfrom
ghpzin:pr-onetbb-gcc15

Conversation

@ghpzin

@ghpzin ghpzin commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

Fixes build failure with gcc15:

FAILED: [code=1] test/CMakeFiles/test_concurrent_unordered_map.dir/tbb/test_concurrent_unordered_map.cpp.o
...
/nix/store/rd8c9w16nwys8yz1a9j2g2nhjn07464r-gcc-15.2.0/include/c++/15.2.0/bits/new_allocator.h:198:11:
error: array subscript 2 is outside array bounds of
'StaticSharedCountingAllocator<std::allocator<tbb::detail::d2::list_node<long unsigned int> > >::value_type [1]'
{aka 'tbb::detail::d2::list_node<long unsigned int> [1]'} [-Werror=array-bounds=]
  198 |         { __p->~_Up(); }
      |           ^~~
compilation terminated due to -Wfatal-errors.
cc1plus: all warnings being treated as errors
...
FAILED: [code=1] test/CMakeFiles/test_concurrent_unordered_set.dir/tbb/test_concurrent_unordered_set.cpp.o
...
/build/source/src/tbb/../../include/tbb/../oneapi/tbb/detail/_concurrent_unordered_base.h:172:20:
error: array subscript 'tbb::detail::d2::value_node<AllocatorAwareData<std::scoped_allocator_adaptor<std::allocator<int> > >,
long unsigned int>[0]' is partly outside array bounds of 'unsigned char [16]' [-Werror=array-bounds=]
  172 |     ~value_node() {}
      |                    ^
compilation terminated due to -Wfatal-errors.
cc1plus: all warnings being treated as errors

Tested build with:

nix-build --expr 'with import ./. {}; onetbb.override { stdenv = gcc15Stdenv; }'

Part of fixes for gcc15 update:
#440456

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

- add patch from merged upstream PR:
https://www.github.com/uxlfoundation/oneTBB/pull/1831
uxlfoundation/oneTBB@712ad98

Fixes build failure with gcc15:
```
FAILED: [code=1] test/CMakeFiles/test_concurrent_unordered_map.dir/tbb/test_concurrent_unordered_map.cpp.o
...
/nix/store/rd8c9w16nwys8yz1a9j2g2nhjn07464r-gcc-15.2.0/include/c++/15.2.0/bits/new_allocator.h:198:11:
error: array subscript 2 is outside array bounds of
'StaticSharedCountingAllocator<std::allocator<tbb::detail::d2::list_node<long unsigned int> > >::value_type [1]'
{aka 'tbb::detail::d2::list_node<long unsigned int> [1]'} [-Werror=array-bounds=]
  198 |         { __p->~_Up(); }
      |           ^~~
compilation terminated due to -Wfatal-errors.
cc1plus: all warnings being treated as errors
...
FAILED: [code=1] test/CMakeFiles/test_concurrent_unordered_set.dir/tbb/test_concurrent_unordered_set.cpp.o
...
/build/source/src/tbb/../../include/tbb/../oneapi/tbb/detail/_concurrent_unordered_base.h:172:20:
error: array subscript 'tbb::detail::d2::value_node<AllocatorAwareData<std::scoped_allocator_adaptor<std::allocator<int> > >,
long unsigned int>[0]' is partly outside array bounds of 'unsigned char [16]' [-Werror=array-bounds=]
  172 |     ~value_node() {}
      |                    ^
compilation terminated due to -Wfatal-errors.
cc1plus: all warnings being treated as errors
```
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Sep 25, 2025
@ghpzin ghpzin marked this pull request as ready for review September 25, 2025 20:19
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 25, 2025
@silvanshade

Copy link
Copy Markdown
Member

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot

Copy link
Copy Markdown
Contributor

@silvanshade merge not permitted (#305350):
R-Ryantm Maintainer merge: pr author is not r-ryantm
CommitterPR: pr author is not committer

@MatthewCroughan MatthewCroughan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onetbb doesn't cut releases very often so this makes sense

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 11, 2025
@nixpkgs-ci nixpkgs-ci Bot enabled auto-merge November 5, 2025 07:07
@nixpkgs-ci

nixpkgs-ci Bot commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

@silvanshade wants to merge this PR.

Requirements to merge this PR with @NixOS/nixpkgs-merge-bot merge:

  • ✅ PR targets a development branch.
  • ✅ PR touches only files of packages in pkgs/by-name/.
  • ✅ PR is at least one of:
    • ✅ Approved by a committer.
    • ⬜ Backported via label.
    • ⬜ Opened by a committer.
    • ⬜ Opened by r-ryantm.
  • ✅ silvanshade is a member of @NixOS/nixpkgs-maintainers.
  • ✅ silvanshade is a maintainer of all touched packages.

✔️ Enabled Auto Merge (#306934)

@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Nov 5, 2025
@nixpkgs-ci nixpkgs-ci Bot added this pull request to the merge queue Nov 5, 2025
Merged via the queue into NixOS:staging with commit 91183fb Nov 5, 2025
39 checks passed
@ghpzin ghpzin deleted the pr-onetbb-gcc15 branch November 5, 2025 08:10
@fabianhjr fabianhjr mentioned this pull request Dec 1, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants