assimp: fix build with gcc15#446108
Merged
Merged
Conversation
- add patch from merged upstream PR: https://www.github.com/assimp/assimp/pull/6283 Fixes build failure with gcc15: ``` /build/source/code/AssetLib/X3D/X3DGeoHelper.cpp: In static member function 'static void Assimp::X3DGeoHelper::coordIdx_str2lines_arr(const std::vector<int>&, std::vector<aiFace>&)': /build/source/code/AssetLib/X3D/X3DGeoHelper.cpp:194:20: error: array subscript -1 is outside array bounds of 'int [2305843009213693951]' [-Werror=array-bounds=] 194 | if (f_data.back() != (-1)) { | ~~~~~~~~~~~^~ In file included from /nix/store/9jzssiinw6a2dib6k3hzd48j6ywck4iw-gcc-15.2.0/include/c++/15.2.0/x86_64-unknown-linux-gnu/bits/c++allocator.h:33, from /nix/store/9jzssiinw6a2dib6k3hzd48j6ywck4iw-gcc-15.2.0/include/c++/15.2.0/bits/allocator.h:46, from /nix/store/9jzssiinw6a2dib6k3hzd48j6ywck4iw-gcc-15.2.0/include/c++/15.2.0/string:45, from /build/source/include/assimp/types.h:78, from /build/source/code/AssetLib/X3D/X3DGeoHelper.h:6, from /build/source/code/AssetLib/X3D/X3DGeoHelper.cpp:1: ```
02a23f6 to
c529f16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.github.com/assimp/assimp/pull/6283
Fixes build failure with gcc15:
Tested build with:
nix-build --expr 'with import ./. {}; assimp.override { stdenv = gcc15Stdenv; }'Part of fixes for gcc15 update:
#440456
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.