xvidcore: fix build with gcc15, cleanup#446034
Merged
Merged
Conversation
- add patch from fedora
Fixes build failure with gcc15:
```
In file included from ../../src/bitstream/bitstream.h:31,
from ../../src/decoder.c:40:
../../src/bitstream/../encoder.h:45:13: error: 'bool' cannot be defined via 'typedef'
45 | typedef int bool;
| ^~~~
../../src/bitstream/../encoder.h:45:13: note: 'bool' is a keyword with '-std=c23' onwards
../../src/bitstream/../encoder.h:45:1: warning: useless type name in empty declaration
45 | typedef int bool;
| ^~~~~~~
```
- replace `rec` with `finalAttrs` - remove `with lib;` from `meta` - replace `sha256` with `hash` nix hash to-sri --type sha256 "1xyg3amgg27zf7188kss7y248s0xhh1vv8rrk0j9bcsd5nasxsmf" sha256-ruqulS1Ns5UkmDmjvQOEHWhEhD9aT4TCcf+I96oaz/c=
655978f to
d37a0bc
Compare
Member
|
Was able to build xvidcore from this branch and gcc-15 |
fabianhjr
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xvidcore: fix build with gcc15
Fixes build failure with gcc15:
xvidcore: cleanup
recwithfinalAttrswith lib;frommetasha256withhashnix hash to-sri --type sha256 "1xyg3amgg27zf7188kss7y248s0xhh1vv8rrk0j9bcsd5nasxsmf"
sha256-ruqulS1Ns5UkmDmjvQOEHWhEhD9aT4TCcf+I96oaz/c=
Tested build with:
nix-build --expr 'with import ./. {}; xvidcore.override { stdenv = gcc15Stdenv; }'Part of fixes for gcc15 update:
#440456
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.