grub: fix building with gcc-15#445865
Merged
Merged
Conversation
Ma27
reviewed
Oct 9, 2025
Ma27
left a comment
Member
There was a problem hiding this comment.
Please retarget to staging-nixos since this causes a rebuild of all nixos tests.
Everything in there will usually be merged with the next kernel update, i.e. ~weekly.
See also https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#changes-rebuilding-all-nixos-tests
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
|
Could you please rebase this PR? |
leona-ya
approved these changes
Dec 3, 2025
Merged
via the queue into
NixOS:staging-nixos
with commit Dec 3, 2025
a2dc452
28 of 30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds patches from grub HEAD to allow building grub 2.12 with gcc 15, to prepare upgrading the default compiler from gcc 14 that is planned in #440456
Alternative we could await the release of grub 2.14 that is scheduled for November 7
https://lists.gnu.org/archive/html/grub-devel/2025-08/msg00157.html
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.