Skip to content

haskell.packages.ghc{94,96,98,912}.haskell-language-server: Fix build#444937

Merged
maralorn merged 1 commit into
NixOS:staging-nextfrom
maralorn:fix-hls-all-versions
Sep 25, 2025
Merged

haskell.packages.ghc{94,96,98,912}.haskell-language-server: Fix build#444937
maralorn merged 1 commit into
NixOS:staging-nextfrom
maralorn:fix-hls-all-versions

Conversation

@maralorn

@maralorn maralorn commented Sep 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

I hate it. There was a time where this was actually getting easier, but apparently it is getting harder again. Main problem is that too many packages have a tight coupling to Cabal.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 6.topic: haskell General-purpose, statically typed, purely functional programming language labels Sep 21, 2025
@maralorn maralorn marked this pull request as ready for review September 21, 2025 11:20
@nixpkgs-ci nixpkgs-ci Bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Sep 21, 2025
@wolfgangwalther

wolfgangwalther commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

merge conflict

@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 22, 2025
@maralorn maralorn force-pushed the fix-hls-all-versions branch from ccdfba6 to c86adbf Compare September 22, 2025 17:59
@nixpkgs-ci nixpkgs-ci Bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Sep 22, 2025
@maralorn maralorn force-pushed the fix-hls-all-versions branch from c86adbf to b14eb56 Compare September 22, 2025 19:48
@maralorn

maralorn commented Sep 22, 2025

Copy link
Copy Markdown
Member Author

I hope it’s fixed now?

@maralorn

maralorn commented Sep 22, 2025

Copy link
Copy Markdown
Member Author

At some point something which jujutsu can merge cleanly confused github …

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Sep 22, 2025
@wolfgangwalther

wolfgangwalther commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

Not sure how you tested, but CI tells me that 3 packages are currently "removed":

Removed packages (3)
    haskell.packages.ghc94.haskell-language-server
    haskell.packages.ghc96.haskell-language-server
    haskell.packages.ghc98.haskell-language-server

That's because the haskell package retrie-1.2.3 is currently marked as broken. Apparently this PR changes dependencies in a way that these 3 depend on that?

wolfgangwalther
wolfgangwalther reviewed Sep 23, 2025
View reviewed changes
Comment thread pkgs/development/haskell-modules/configuration-ghc-9.4.x.nix
@maralorn maralorn force-pushed the fix-hls-all-versions branch from b14eb56 to 3bce98b Compare September 24, 2025 20:24
@nixpkgs-ci nixpkgs-ci Bot removed the 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. label Sep 24, 2025
@maralorn

maralorn commented Sep 24, 2025

Copy link
Copy Markdown
Member Author

Next attempt.

@wolfgangwalther

wolfgangwalther commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 444937
Commit: 3bce98bfed6c26282c301505b9e12d8c44767f1d

x86_64-linux

❌ 1 package failed to build:
  • hedgewars
✅ 4 packages built:
  • haskell.packages.ghc912.haskell-language-server
  • haskell.packages.ghc94.haskell-language-server
  • haskell.packages.ghc96.haskell-language-server
  • haskell.packages.ghc98.haskell-language-server

@wolfgangwalther

wolfgangwalther commented Sep 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

hedgewars is already broken on the target branch.

(or rather, a dependency of it physfs)

wolfgangwalther
wolfgangwalther approved these changes Sep 25, 2025
View reviewed changes

@wolfgangwalther wolfgangwalther left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not go through each individual change, but skimmed the diff, LGTM from what I see.

Most importantly: It builds! :)

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 25, 2025
@maralorn maralorn merged commit 8398c1a into NixOS:staging-next Sep 25, 2025
29 of 32 checks passed
@ghpzin ghpzin mentioned this pull request Sep 30, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maralorn @wolfgangwalther