Skip to content

webrtc-audio-processing_1: Fix compilation against gcc15#444039

Merged
fabianhjr merged 1 commit into
NixOS:stagingfrom
FZDSLR:webrtc-audio-processing_1-gcc15
Dec 4, 2025
Merged

webrtc-audio-processing_1: Fix compilation against gcc15#444039
fabianhjr merged 1 commit into
NixOS:stagingfrom
FZDSLR:webrtc-audio-processing_1-gcc15

Conversation

@FZDSLR

@FZDSLR FZDSLR commented Sep 18, 2025

Copy link
Copy Markdown
Contributor

Things done

Fixes ../webrtc/api/task_queue/task_queue_base.h:53:32: error: 'uint32_t' has not been declared when compiling with gcc15Stdenv.

PS: this patch only fixes native build. Doing cross compilation throws errors like /nix/store/bvnb122adsvikb4akybz72cbri5xr96h-binutils-2.44/bin/ld: /nix/store/d6zbr9rmg2kklc18r4a004qqgz8ddvyc-abseil-cpp-aarch64-unknown-linux-gnu-20250814.0/lib/libabsl_base.so: error adding symbols: file in wrong format.


  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Sep 18, 2025
@FZDSLR FZDSLR marked this pull request as draft September 18, 2025 14:47
@nixpkgs-ci nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 18, 2025
@ghpzin

ghpzin commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Could you recheck if cross still fails and undraft PR, if possible as
#440456 comes closer to merging.

From store path, I assume it was something similar to:
pkgsCross.aarch64-multiplatform.webrtc-audio-processing_1
and it builds fine for me with this PR on gcc15.
(I do not do much cross compiling, so maybe that is not it).

@fabianhjr fabianhjr marked this pull request as ready for review December 4, 2025 02:37
@fabianhjr

Copy link
Copy Markdown
Member

This fixes the build failure for x86_64-linux NixOS with gcc15

@fabianhjr fabianhjr added this pull request to the merge queue Dec 4, 2025
@fabianhjr fabianhjr mentioned this pull request Dec 4, 2025
13 tasks
@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 4, 2025
Merged via the queue into NixOS:staging with commit fe67ac4 Dec 4, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants