Skip to content

calceph: init at 4.0.5#438803

Merged
SuperSandro2000 merged 1 commit into
NixOS:masterfrom
activexray:kshila/calceph
Nov 15, 2025
Merged

calceph: init at 4.0.5#438803
SuperSandro2000 merged 1 commit into
NixOS:masterfrom
activexray:kshila/calceph

Conversation

@activexray

@activexray activexray commented Aug 31, 2025

Copy link
Copy Markdown
Contributor

Adds the CALCEPH C library for working with binary ephemeris files.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 31, 2025
@activexray activexray force-pushed the kshila/calceph branch 2 times, most recently from 3c859b5 to fba01c5 Compare August 31, 2025 18:46
@activexray activexray mentioned this pull request Aug 31, 2025
Merged
13 tasks
iamanaws
iamanaws reviewed Sep 1, 2025
View reviewed changes
Comment thread pkgs/by-name/ca/calceph/package.nix
iamanaws
iamanaws reviewed Sep 1, 2025
View reviewed changes
Comment thread pkgs/by-name/ca/calceph/package.nix
@nixpkgs-ci nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 1, 2025
@activexray

activexray commented Sep 1, 2025

Copy link
Copy Markdown
Contributor Author

Took a little tweaking, but I merged your recommendations. Thanks!

@iamanaws

iamanaws commented Sep 1, 2025

Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 438803
Commit: 9c5d4ae8d732fa22faada3d6abafa54f800c80b1 (subsequent changes)
Merge: d30f4fcd6c5b11b29b50d5679b71a50f6803e2ec

Logs: https://github.com/Iamanaws/nixpkgs-review-gha/actions/runs/17367997748

x86_64-linux

✅ 1 package built:
  • calceph

aarch64-linux

✅ 1 package built:
  • calceph

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • calceph

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • calceph

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 2, 2025
@activexray

activexray commented Sep 14, 2025

Copy link
Copy Markdown
Contributor Author

Hey, just checking that there's nothing else that needs to be done before this gets merged. Do we need to ping someone with merge access?

@iamanaws

iamanaws commented Sep 22, 2025

Copy link
Copy Markdown
Member

Hey, just checking that there's nothing else that needs to be done before this gets merged. Do we need to ping someone with merge access?

If you have someone with commit bit that is okay being pinged, then sure

@nixos-discourse

nixos-discourse commented Sep 27, 2025

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2561

SuperSandro2000
SuperSandro2000 reviewed Sep 30, 2025
View reviewed changes
Comment thread pkgs/by-name/ca/calceph/package.nix Outdated
SuperSandro2000
SuperSandro2000 reviewed Sep 30, 2025
View reviewed changes
Comment thread pkgs/by-name/ca/calceph/package.nix Outdated
@activexray

activexray commented Oct 4, 2025

Copy link
Copy Markdown
Contributor Author

@SuperSandro2000 Just committed your suggestions, thanks!

SuperSandro2000
SuperSandro2000 reviewed Oct 5, 2025
View reviewed changes

@SuperSandro2000 SuperSandro2000 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm

Comment thread pkgs/by-name/ca/calceph/package.nix Outdated
@activexray @iamanaws
calceph: init at 4.0.5
aaf94da 
Co-authored-by: Angel J <78835633+Iamanaws@users.noreply.github.com>
@activexray

activexray commented Oct 13, 2025

Copy link
Copy Markdown
Contributor Author

@SuperSandro2000 if you don't mind taking a final look at this, this should be good to merge!

@activexray

activexray commented Nov 8, 2025

Copy link
Copy Markdown
Contributor Author

@SuperSandro2000 Do you mind taking another look and/or merging? Thanks!

@nixos-discourse

nixos-discourse commented Nov 15, 2025

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/6070

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Nov 15, 2025
@SuperSandro2000

SuperSandro2000 commented Nov 15, 2025

Copy link
Copy Markdown
Member

Your mention got buried in the other 500 notifications 😅

@activexray

activexray commented Nov 15, 2025

Copy link
Copy Markdown
Contributor Author

Totally understood, I just didn't know who else to ping with merge access 😅

TYSM!

Merged via the queue into NixOS:master with commit 2c3407c Nov 15, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000
1 more reviewer
@iamanaws iamanaws iamanaws approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@activexray @iamanaws @nixos-discourse @SuperSandro2000