Skip to content

[staging-next] mesa.llvmpipeHook: fix GLX, add GBM, add comments#428569

Merged
K900 merged 1 commit intoNixOS:staging-nextfrom
K900:improve-llvmpipe-hook
Jul 26, 2025
Merged

[staging-next] mesa.llvmpipeHook: fix GLX, add GBM, add comments#428569
K900 merged 1 commit intoNixOS:staging-nextfrom
K900:improve-llvmpipe-hook

Conversation

@K900
Copy link
Copy Markdown
Contributor

@K900 K900 commented Jul 26, 2025 •
edited
Loading

Supersedes #428552. All of lomiri builds now.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@K900 K900 changed the title mesa.llvmpipeHook: fix GLX, add GBM, add comments [staging-next] mesa.llvmpipeHook: fix GLX, add GBM, add comments Jul 26, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 26, 2025
@qbisi
Copy link
Copy Markdown
Contributor

qbisi commented Jul 26, 2025

may be out of topic, if we want to do some opencl related check. we may need to set

export OCL_ICD_VENDORS="@mesa_opencl@/etc/OpenCL/vendors"

since mesa^opencl is heavy, should we separate this to another hook?

@K900
Copy link
Copy Markdown
Contributor Author

K900 commented Jul 26, 2025

We can think about that when it becomes an issue.

@qbisi
Copy link
Copy Markdown
Contributor

qbisi commented Jul 26, 2025

In fact, python3Packages.pyopencl are doing check with pocl backend.

nixpkgs/pkgs/by-name/po/pocl/setup-hook.sh

Lines 1 to 6 in 7fd36ee

preCheckHooks+=('setupPoclCheck')
preInstallCheckHooks+=('setupPoclCheck')
setupPoclCheck () {
export OCL_ICD_VENDORS="@out@/etc/OpenCL/vendors"
}

python3Packages.loopy may also want a portable opencl backend doing check. See

nixpkgs/pkgs/development/python-modules/loopy/default.nix

Lines 76 to 77 in 7fd36ee

# pyopencl._cl.LogicError: clGetPlatformIDs failed: PLATFORM_NOT_FOUND_KHR
doCheck = false;

These packages' test should also work with mesa's llvmpipe backend.
I am seeking a new setuphook setting opencl backend for doing opencl related check, any suggestion.

@K900
Copy link
Copy Markdown
Contributor Author

K900 commented Jul 26, 2025

I don't think we should be relying on rusticl-on-llvmpipe, which is explicitly experimental.

@K900 K900 merged commit 650c5fc into NixOS:staging-next Jul 26, 2025
30 of 33 checks passed
@K900 K900 deleted the improve-llvmpipe-hook branch July 27, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@K900 @qbisi