Skip to content

bash-language-server: remove deletion of nonexistent file#426372

Merged
Scrumplex merged 1 commit intoNixOS:masterfrom
andresilva:andre/bash-language-server-fix
Jul 18, 2025
Merged

bash-language-server: remove deletion of nonexistent file#426372
Scrumplex merged 1 commit intoNixOS:masterfrom
andresilva:andre/bash-language-server-fix

Conversation

@andresilva
Copy link
Copy Markdown
Member

@andresilva andresilva commented Jul 18, 2025 •
edited
Loading 

bash-language-server> rm: cannot remove 'node_modules/.pnpm-workspace-state.json': No such file or directory
error: builder for '/nix/store/hfaqw9nxj86qxf9x4qw80ym3mmvi9jxr-bash-language-server-5.6.0.drv' failed with exit code 1;

Probably behavior changed with #425610.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and others READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 18, 2025
@nix-owners nix-owners bot requested review from doronbehar and gepbird July 18, 2025 13:12
@gepbird
Copy link
Copy Markdown
Contributor

gepbird commented Jul 18, 2025

Probably behavior changed with #420432.

On that PR bash-language-server built, I'll take a look soon

@gepbird
Copy link
Copy Markdown
Contributor

gepbird commented Jul 18, 2025

4ff4f8b is the first bad commit

@gepbird gepbird mentioned this pull request Jul 18, 2025
Merged
13 tasks
@gepbird gepbird requested a review from Scrumplex July 18, 2025 13:53
gepbird
gepbird approved these changes Jul 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gepbird gepbird left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, looks good!

Since the bad commit was backported, it's also broken on stable too :/ Nevermind, on stable there's an older version of this package without the now broken rm

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jul 18, 2025
@andresilva
Copy link
Copy Markdown
Member Author

andresilva commented Jul 18, 2025

4ff4f8b is the first bad commit

Yeah I actually wanted to reference that PR instead since it was the latest change to pnpm.

@Scrumplex
Copy link
Copy Markdown
Member

Scrumplex commented Jul 18, 2025

Sorry about the merge of the pnpm bump. I thought I ran nixpkgs-review on it but I must have forgotten it as I was also building >1000 packages for a different package.

@Scrumplex Scrumplex merged commit 9ef1701 into NixOS:master Jul 18, 2025
35 of 38 checks passed
@gepbird gepbird mentioned this pull request Jul 19, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Scrumplex Scrumplex Scrumplex approved these changes

@gepbird gepbird gepbird approved these changes

@doronbehar doronbehar Awaiting requested review from doronbehar

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andresilva @gepbird @Scrumplex