Skip to content

systemd.disallowedReferences: avoid null values#426071

Merged
vcunat merged 1 commit intoNixOS:masterfrom
vcunat:p/systemd-disallowedReferences
Jul 19, 2025
Merged

systemd.disallowedReferences: avoid null values#426071
vcunat merged 1 commit intoNixOS:masterfrom
vcunat:p/systemd-disallowedReferences

Conversation

@vcunat
Copy link
Copy Markdown
Member

@vcunat vcunat commented Jul 17, 2025

hydra-queue-runner complains like this:

loading build 302783324 (nixpkgs:cross-trunk:rpi-musl.mpg123.x86_64-linux)
queue monitor: error:
       … while loading build 302783324:
       … while parsing derivation '/nix/store/8r46dmzzchv9jhb09y8dlih4h5k6smkm-systemd-minimal-armv6l-unknown-linux-musleabihf-257.6.drv'
       error: attribute 'disallowedReferences' must be a list of strings
checking the queue for builds...
loading build 302783295 (nixpkgs:cross-trunk:rpi-musl.mpg123.aarch64-darwin)

glibcLocales is the one that's null in this case, on (some) cross-builds.

This shouldn't cause a rebuild on native linux builds.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

hydra-queue-runner complains like this:
  loading build 302783324 (nixpkgs:cross-trunk:rpi-musl.mpg123.x86_64-linux)
  queue monitor: error:
         … while loading build 302783324:
         … while parsing derivation '/nix/store/8r46dmzzchv9jhb09y8dlih4h5k6smkm-systemd-minimal-armv6l-unknown-linux-musleabihf-257.6.drv'
         error: attribute 'disallowedReferences' must be a list of strings
  checking the queue for builds...
  loading build 302783295 (nixpkgs:cross-trunk:rpi-musl.mpg123.aarch64-darwin)
@vcunat
Copy link
Copy Markdown
Member Author

vcunat commented Jul 17, 2025

I don't think this issue would cause problems on 25.05, but why not backport.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. labels Jul 17, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 17, 2025
@vcunat vcunat merged commit 524e9a2 into NixOS:master Jul 19, 2025
32 of 34 checks passed
@vcunat vcunat deleted the p/systemd-disallowedReferences branch July 19, 2025 09:43
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci bot commented Jul 19, 2025

Successfully created backport PR for release-25.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants