robotframework-browser: init at 19.6.2 by tobiasBora · Pull Request #425503 · NixOS/nixpkgs

tobiasBora · 2025-07-15T16:59:29Z

Things done

Fix #292321, it should work now.

To test, start a shell with

(pkgs.python3.withPackages (ps: with ps; [
      robotframework robotframework-browser
    ]))

create a file test.robot:

*** Settings ***
Library   Browser

*** Test Cases ***
Example Test
    New Page    https://playwright.dev
    Get Text    h1    contains    Playwright

and run:

$ robot test.robot

all tests should pass.

Add a 👍 reaction to pull requests you find important.

pkgs/development/python-modules/robotframework-browser/default.nix

tobiasBora · 2025-07-26T12:34:05Z

Fix #292321, it should work now.

drupol · 2025-07-26T12:50:01Z

In overall and even if it is totally optional, try to sort derivation attributes sorted in the natural way, similar to the majority of derivations in this repo.

tobiasBora · 2025-07-26T13:10:26Z

@drupol I was indeed mostly trying to make this derivation work and spent little time reorganizing the sections. I did my best to have a coherent ordering, hope it is good enough.

pkgs/development/python-modules/robotframework-browser/default.nix

drupol

https://github.com/NixOS/nixpkgs/pull/427423

pkgs/development/python-modules/robotframework-browser/default.nix

drupol

#418147

pkgs/development/python-modules/robotframework-browser/default.nix

drupol · 2025-07-27T07:27:14Z

Please squash the commits

tobiasBora · 2025-07-27T11:03:18Z

@drupol I did that since I had no access to my computer and I was expecting the final merger to be able to apply the squash at the last step. Anyway, I just did it.

drupol · 2025-07-27T15:23:31Z

@drupol I did that since I had no access to my computer and I was expecting the final merger to be able to apply the squash at the last step. Anyway, I just did it.

We usually don't do that, the PR author need to clean his own PR and not rely on someone else to do it...

drupol · 2025-07-27T20:20:54Z

pkgs/development/python-modules/robotframework-browser/default.nix

+    cat >> $out/lib/python3.13/site-packages/Browser/__init__.py <<EOF
+    import os
+    if not "PLAYWRIGHT_BROWSERS_PATH" in os.environ:
+        os.environ["PLAYWRIGHT_BROWSERS_PATH"] = "${playwright-driver.browsers}"
+    if not "PLAYWRIGHT_SKIP_VALIDATE_HOST_REQUIREMENTS" in os.environ:
+        os.environ["PLAYWRIGHT_SKIP_VALIDATE_HOST_REQUIREMENTS"] = "true"
+    EOF
+  '';


Pretty sure this is wrong. This should be done as a patch, perhaps using replaceVars to substitute the path.

Thanks. I guess it should be done in patch phase indeed. But why can't I use cat instead of patch? Seems like cat is more robust than a patch since the patch will fail when the init file changes.

You're adding a file in the Browser package. With a patch you won't need the path at all. Just patch the src and that's it.

iwanb · 2025-07-31T19:54:36Z

Not sure what's the best way to handle this, but FYI upstream pins some packages like protobuf and grpcio, which means this package will break whenever these get updates in nixpkgs (or when you want to update this package but grpcio is not updated yet). They also understandably don't want to support relaxing the version checks. AFAIK the pinning is not really necessary, if we build the protobufs and run the tests it should be fine to relax it on our side, but of course it's better if we can honor it.

I also noticed they just released a new version which moves to pyproject.toml. It also updates grpcio, so that's a good example of the problem you'll get, now you have to wait for grpcio to be updated first, which will then break this merge request/package, then update to the new version to unbreak it.

SuperSandro2000 · 2025-07-31T20:07:34Z

pkgs/development/python-modules/robotframework-browser/default.nix

+  # + grpc_tools_node_protoc already includes the plugin and is not runnable via npm
+  # since nix directly builds it from C++ sources to avoid to use pre-build binaries
+  # downloaded by npm
+  patchPhase = ''


Suggested change

patchPhase = ''

postPatch = ''

we do not want to break patches

I'm implementing this now in my next update, but still curious: what's wrong with adding a patchPhase? Aren't all hooks involving patch adding stuff to postPatch already?

SuperSandro2000 · 2025-07-31T20:07:43Z

pkgs/development/python-modules/robotframework-browser/default.nix

+    runHook prePatch
+    substituteInPlace ./Browser/playwright.py \
+      --replace-fail '(installation_dir / "node_modules").is_dir()' 'True'
+    substituteInPlace ./tasks.py \
+      --replace-fail 'c.run("pip install -U pip")' 'return' \
+      --replace-fail 'npm run grpc_tools_node_protoc' 'grpc_tools_node_protoc' \
+      --replace-fail ' -- ' ' '
+    substituteInPlace ./package.json \
+      --replace-fail '"grpc-tools": "^1.13.0",' ' '
+    sed -i '/--plugin=protoc-gen-grpc/d' ./tasks.py
+    runHook postPatch


Suggested change

runHook prePatch

substituteInPlace ./Browser/playwright.py \

--replace-fail '(installation_dir / "node_modules").is_dir()' 'True'

substituteInPlace ./tasks.py \

--replace-fail 'c.run("pip install -U pip")' 'return' \

--replace-fail 'npm run grpc_tools_node_protoc' 'grpc_tools_node_protoc' \

--replace-fail ' -- ' ' '

substituteInPlace ./package.json \

--replace-fail '"grpc-tools": "^1.13.0",' ' '

sed -i '/--plugin=protoc-gen-grpc/d' ./tasks.py

runHook postPatch

substituteInPlace ./Browser/playwright.py \

--replace-fail '(installation_dir / "node_modules").is_dir()' 'True'

substituteInPlace ./tasks.py \

--replace-fail 'c.run("pip install -U pip")' 'return' \

--replace-fail 'npm run grpc_tools_node_protoc' 'grpc_tools_node_protoc' \

--replace-fail ' -- ' ' '

substituteInPlace ./package.json \

--replace-fail '"grpc-tools": "^1.13.0",' ' '

sed -i '/--plugin=protoc-gen-grpc/d' ./tasks.py

nix-owners bot requested a review from natsukium July 15, 2025 17:01

tobiasBora mentioned this pull request Jul 15, 2025

Build failure: playwright-driver.browsers #425505

Closed

3 tasks

tobiasBora force-pushed the add_robotframework-browser branch from 57d9628 to 1b8895d Compare July 15, 2025 17:05

nix-owners bot requested a review from nzhang-zh July 15, 2025 17:12

tobiasBora marked this pull request as draft July 16, 2025 08:12

tobiasBora force-pushed the add_robotframework-browser branch from 1b8895d to fff9229 Compare July 16, 2025 13:39

nixpkgs-ci bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 16, 2025

tobiasBora force-pushed the add_robotframework-browser branch 2 times, most recently from 266130c to 8760277 Compare July 26, 2025 12:30

drupol reviewed Jul 26, 2025

View reviewed changes

pkgs/development/python-modules/robotframework-browser/default.nix Outdated Show resolved Hide resolved

tobiasBora force-pushed the add_robotframework-browser branch from 8760277 to 531859f Compare July 26, 2025 12:31

tobiasBora marked this pull request as ready for review July 26, 2025 12:32

tobiasBora mentioned this pull request Jul 26, 2025

Package request: robotframework-browserlibrary #292321

Closed

tobiasBora force-pushed the add_robotframework-browser branch from 531859f to 2bab342 Compare July 26, 2025 12:36

tobiasBora changed the title ~~DRAFT: robotframework-browser: init at 19.6.0~~ robotframework-browser: init at 19.6.0 Jul 26, 2025

tobiasBora changed the title ~~robotframework-browser: init at 19.6.0~~ robotframework-browser: init at 19.6.2 Jul 26, 2025

tobiasBora force-pushed the add_robotframework-browser branch from 2bab342 to 562a9d0 Compare July 26, 2025 13:09

drupol reviewed Jul 26, 2025

View reviewed changes

pkgs/development/python-modules/robotframework-browser/default.nix Outdated Show resolved Hide resolved

pkgs/development/python-modules/robotframework-browser/default.nix Outdated Show resolved Hide resolved

tobiasBora force-pushed the add_robotframework-browser branch from 562a9d0 to cf69cba Compare July 26, 2025 19:01

drupol requested changes Jul 26, 2025

View reviewed changes

pkgs/development/python-modules/robotframework-browser/default.nix Outdated Show resolved Hide resolved

tobiasBora force-pushed the add_robotframework-browser branch from cf69cba to 98fef45 Compare July 26, 2025 19:08

tobiasBora requested a review from drupol July 26, 2025 19:12

drupol reviewed Jul 26, 2025

View reviewed changes

pkgs/development/python-modules/robotframework-browser/default.nix Outdated Show resolved Hide resolved

tobiasBora requested a review from drupol July 27, 2025 07:24

robotframework-browser: init at 19.6.2

3dbd227

tobiasBora force-pushed the add_robotframework-browser branch from 89c3e9d to 3dbd227 Compare July 27, 2025 11:01

drupol reviewed Jul 27, 2025

View reviewed changes

SuperSandro2000 reviewed Jul 31, 2025

View reviewed changes

nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 29, 2026

Uh oh!

Conversation

tobiasBora commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

Uh oh!

tobiasBora commented Jul 26, 2025

Uh oh!

drupol commented Jul 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tobiasBora commented Jul 26, 2025

Uh oh!

Uh oh!

Uh oh!

drupol left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

drupol left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

drupol commented Jul 27, 2025

Uh oh!

tobiasBora commented Jul 27, 2025

Uh oh!

drupol commented Jul 27, 2025

Uh oh!

drupol Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

tobiasBora Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

drupol Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

iwanb commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SuperSandro2000 Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

tobiasBora Aug 10, 2025

Choose a reason for hiding this comment

Uh oh!

SuperSandro2000 Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tobiasBora commented Jul 15, 2025 •

edited

Loading

drupol commented Jul 26, 2025 •

edited

Loading

iwanb commented Jul 31, 2025 •

edited

Loading