php85: init at 8.5.1 #422308
Open
php85: init at 8.5.1 #422308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c36c14e to
5fc3895
Compare
a713c8e to
10b8170
Compare
b1298fa to
356455d
Compare
Contributor
|
Before this gets merged we should review external (pecl) extensions most likely they'll fail. I'll try to build all of them tomorrow. I tried to nix-review on this PR but I run out of memory (32gb). I'll reduce number of builder and give it another go. |
Contributor
|
a29ce80 to
b0b1ae7
Compare
Member
|
Can you elaborate why this is needed, then? |
Contributor
|
uri should be in optionals 8.5+ the same as lexbor as it was introduced in php 8.5 |
Contributor
Author
I'll be investigating this further tomorrow,went to bed already. I'll let you know more asap. |
Contributor
|
Overall lexbor and uri extensions are more or less shared libs. They don't have .so files and aren't toggle by a user. They're always enabled. |
Member
This doesn't answer my question though. How is this package serving any value? This is literally an empty directory and nothing else. Assuming this actually made a difference for you, we should carefully investigate what happened because we're clearly not understanding what's going on currently. |
Contributor
|
I think dev part makes it work: Maybe mkdir and cp should in the same condition |
Member
|
Ah right, it's the headers making the difference. IMHO we're holding this wrong then: like, why have a "package" for something that's not supposed to be its own package? Sure, header-only libraries are a thing, but If we need it anyways by default, what's the reason for not making this part of |
Al2Klimov
reviewed
Jan 14, 2026
Contributor
Al2Klimov
left a comment
There was a problem hiding this comment.
FWIW, I needed this (for services.icingaweb2.*) and tried the PR. Some extensions didn't build, see below.
(import (builtins.fetchTarball {
# https://github.com/NixOS/nixpkgs/pull/422308
url = "https://github.com/drupol/nixpkgs/archive/b0b1ae7d975ceba84c75d1c7260d583d8f89c904.tar.gz";
}) { }).php85.withExtensions (
{ all, ... }:
with (builtins.trace (builtins.concatStringsSep " " (builtins.attrNames all)) all);
[
#amqp # marked as broken
#apcu # marked as broken
#ast # marked as broken
bcmath
bz2
calendar
#couchbase # marked as broken
ctype
curl
#datadog_trace # marked as broken
dba
decimal
#dom # FAILED TEST SUMMARY
ds
enchant
event
excimer
exif
ffi
fileinfo
filter
ftp
gd
gettext
gmp
#gnupg # marked as broken
#grpc # implicit declaration of function 'zend_exception_get_default'
iconv
#igbinary # ext/standard/php_smart_string.h: No such file or directory
#imagick # ext/standard/php_smart_string.h: No such file or directory
#imap # marked as broken
inotify
intl
#ioncube-loader # marked as broken
ldap
lexbor
#luasandbox # passing argument 2 of 'zend_register_internal_class_ex' makes pointer from integer without a cast
#mailparse # ext/standard/php_smart_string.h: No such file or directory
maxminddb
mbstring
#memcache # ext/standard/php_smart_string_public.h: No such file or directory
memcached
meminfo
memprof
mongodb
msgpack
mysqli
mysqlnd
oci8
opcache
openssl
#openssl-legacy # has been removed
#openswoole # marked as broken
opentelemetry
#parallel # marked as broken
pcntl
pcov
pdlib
pdo
pdo_dblib
pdo_mysql
#pdo_oci # marked as broken
pdo_odbc
pdo_pgsql
pdo_sqlite
#pdo_sqlsrv # marked as broken
pgsql
#phalcon # ext/standard/php_smart_string.h: No such file or directory
#php-spx # deprecated
pinba
posix
protobuf
pspell
rdkafka
readline
redis
relay
#rrd # ext/standard/php_smart_string.h: No such file or directory
session
shmop
simplexml
smbclient
snmp
#snuffleupagus # too few arguments to function 'php_setcookie'
soap
sockets
sodium
#spx # marked as broken
sqlite3
sqlsrv
ssh2
#swoole # marked as broken
systemd
sysvmsg
sysvsem
sysvshm
#tideways # Unsupported PHP version
tidy
tokenizer
uri
uuid
uv
vld
wikidiff2
xdebug
xml
#xmlreader # see dom
xmlwriter
#xsl # see dom
yaml
#zend_test # see dom
zip
zlib
zstd
]
)
Contributor
Author
|
Looking for help on this one as I am no longer using PHP on a regular basis, it's a bit difficult for me to find time to invest in this PR |
Contributor
|
In the upcoming days I'll PR some extension updates to reduce the amount of packages we have to mark as broken, so we have less merge conflicts. |
This was referenced Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.