Skip to content

tcl,tk: 8.6.15 -> 8.6.16#420613

Merged
fgaz merged 1 commit intoNixOS:stagingfrom
fgaz:tcl/8.6.16
Jul 19, 2025
Merged

tcl,tk: 8.6.15 -> 8.6.16#420613
fgaz merged 1 commit intoNixOS:stagingfrom
fgaz:tcl/8.6.16

Conversation

@fgaz
Copy link
Copy Markdown
Member

@fgaz fgaz commented Jun 27, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: tcl Dynamic, multi-paradigm programming language labels Jun 27, 2025
@fgaz fgaz requested a review from agbrooks June 30, 2025 11:54
@fgaz
Copy link
Copy Markdown
Member Author

fgaz commented Jul 10, 2025

Ping @agbrooks

agbrooks
agbrooks approved these changes Jul 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@agbrooks agbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! My apologies for the delay on the review, @fgaz.

Would you like to add yourself as a maintainer? I don't want to be the bottleneck on useful maintenance PRs like this, and I really appreciate your recent improvements to nixpkgs Tcl packages. :)

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 12, 2025
@fgaz fgaz merged commit b8ea17d into NixOS:staging Jul 19, 2025
33 of 34 checks passed
@fgaz fgaz deleted the tcl/8.6.16 branch July 19, 2025 13:54
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci bot commented Jul 19, 2025

Successfully created backport PR for staging-25.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jul 19, 2025
Merged
1 task
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jul 19, 2025
@fgaz
Copy link
Copy Markdown
Member Author

fgaz commented Jul 19, 2025 •
edited
Loading

Would you like to add yourself as a maintainer? I don't want to be the bottleneck on useful maintenance PRs like this, and I really appreciate your recent improvements to nixpkgs Tcl packages. :)

I'm already spread very thin so I'd rather not. However I did add myself to the OWNERS file so I'll receive notifications anyway.

nixpkgs/ci/OWNERS

Lines 216 to 221 in 13dc8d5

# Tcl
/pkgs/development/interpreters/tcl @fgaz
/pkgs/development/libraries/tk @fgaz
/pkgs/top-level/tcl-packages.nix @fgaz
/pkgs/development/tcl-modules @fgaz
/doc/languages-frameworks/tcl.section.md @fgaz

By the way, would you like to be added there as well? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@agbrooks agbrooks agbrooks approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: tcl Dynamic, multi-paradigm programming language 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fgaz @agbrooks @leona-ya