Skip to content

nodejs_24: 24.2.0 -> 24.3.0#419714

Merged
drupol merged 1 commit intoNixOS:masterfrom
aduh95:nodejs-24
Jun 25, 2025
Merged

nodejs_24: 24.2.0 -> 24.3.0#419714
drupol merged 1 commit intoNixOS:masterfrom
aduh95:nodejs-24

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Jun 24, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment labels Jun 24, 2025
drupol
drupol approved these changes Jun 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@drupol drupol merged commit cf2d8d4 into NixOS:master Jun 25, 2025
28 of 30 checks passed
@aduh95 aduh95 deleted the nodejs-24 branch June 25, 2025 07:03
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci bot commented Jun 25, 2025

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-419714-to-release-25.05 origin/release-25.05
cd .worktree/backport-419714-to-release-25.05
git switch --create backport-419714-to-release-25.05
git cherry-pick -x cda781665a46903804971722ec010705be7d8591

@aduh95 aduh95 mentioned this pull request Jun 25, 2025
Merged
13 tasks
@mdaniels5757 mdaniels5757 added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 25, 2025
@happysalada
Copy link
Copy Markdown
Contributor

happysalada commented Jun 28, 2025

There seems to be a linux build failure. Would submit an error log, but I don't have time.

@MisileLab
Copy link
Copy Markdown
Contributor

MisileLab commented Jun 29, 2025

There seems to be a linux build failure. Would submit an error log, but I don't have time.

#420424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drupol drupol drupol approved these changes

Assignees

No one assigned

Labels

6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95 @happysalada @MisileLab @drupol @mdaniels5757