Skip to content

ld-audit-search-mod: init at 0-unstable-2025-06-19#418244

Merged
Ma27 merged 2 commits intoNixOS:masterfrom
Atry:ld-audit-search-mod
Aug 7, 2025
Merged

ld-audit-search-mod: init at 0-unstable-2025-06-19#418244
Ma27 merged 2 commits intoNixOS:masterfrom
Atry:ld-audit-search-mod

Conversation

@Atry
Copy link
Copy Markdown
Contributor

@Atry Atry commented Jun 19, 2025 •
edited
Loading

Things done

This PR adds ld-audit-search-mod, a potential solution for #327854

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

I manually tested it. It works fine as documented in the upstream README.

Add a 👍 reaction to pull requests you find important.

@Atry Atry marked this pull request as ready for review June 19, 2025 19:49
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 19, 2025
@Atry Atry force-pushed the ld-audit-search-mod branch from 24761d6 to 4c8c690 Compare June 19, 2025 19:55
@Atry Atry changed the title ld-audit-search-mod: init at unstable-2025-02-11 ld-audit-search-mod: init at unstable-2025-06-18 Jun 19, 2025
@Atry Atry force-pushed the ld-audit-search-mod branch from 4c8c690 to 03266ea Compare June 19, 2025 20:00
@Atry Atry changed the title ld-audit-search-mod: init at unstable-2025-06-18 ld-audit-search-mod: init at unstable-2025-06-19 Jun 19, 2025
@Atry Atry force-pushed the ld-audit-search-mod branch from 03266ea to d0fb5e4 Compare June 19, 2025 20:02
@Atry Atry requested review from a user and thufschmitt June 20, 2025 05:38
@Atry Atry changed the title ld-audit-search-mod: init at unstable-2025-06-19 ld-audit-search-mod: init at 0-unstable-2025-06-19 Jun 21, 2025
@ghost ghost removed their request for review June 21, 2025 16:37
@Atry Atry force-pushed the ld-audit-search-mod branch from ca0da16 to 17ff7b1 Compare June 22, 2025 23:05
@Atry Atry requested a review from a user June 22, 2025 23:14
@ghost ghost removed their request for review June 23, 2025 06:10
@Atry Atry requested a review from a user June 24, 2025 01:33
@ghost ghost removed their request for review June 24, 2025 01:52
@Atry
Copy link
Copy Markdown
Contributor Author

Atry commented Jun 24, 2025 •
edited
Loading

I don't know how to test it

The upstream README provides instruction about how to use it
https://github.com/DDoSolitary/ld-audit-search-mod?tab=readme-ov-file#use-with-nixos

@Atry Atry requested review from oxij and pennae June 24, 2025 05:52
@Atry Atry requested a review from Ma27 July 1, 2025 19:43
@Atry Atry requested a review from copumpkin July 25, 2025 15:50
@Atry
Copy link
Copy Markdown
Contributor Author

Atry commented Jul 25, 2025

Hi @copumpkin, do you want to review this PR, as you are the assignee of #327854?

@fricklerhandwerk fricklerhandwerk removed their request for review July 25, 2025 20:31
@Atry Atry requested a review from timokau July 30, 2025 17:51
@Atry Atry mentioned this pull request Jul 30, 2025
Draft
10 tasks
@Atry
Copy link
Copy Markdown
Contributor Author

Atry commented Jul 30, 2025

This PR just adds the package, and it does not include any NixOS configuration. I suppose it should subject to a quick review as other init package PRs.

@Ma27 Can we get this PR merged? It does not affect any existing configuration.

@Atry Atry requested a review from Aleksanaa July 30, 2025 18:08
Ma27
Ma27 reviewed Jul 30, 2025
View reviewed changes
Ma27
Ma27 reviewed Jul 30, 2025
View reviewed changes
@Atry Atry force-pushed the ld-audit-search-mod branch from bf70b89 to b646b55 Compare July 31, 2025 07:57
@Atry Atry requested a review from Ma27 July 31, 2025 07:59
@nixpkgs-ci nixpkgs-ci bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jul 31, 2025
@Atry Atry force-pushed the ld-audit-search-mod branch from b646b55 to 7ee1863 Compare July 31, 2025 23:14
@Atry
Copy link
Copy Markdown
Contributor Author

Atry commented Aug 5, 2025

@Ma27 I updated the PR according to your suggested changes. Do you think this PR is ready to merge?

@Atry Atry mentioned this pull request Aug 6, 2025
Closed
11 tasks
@Atry Atry requested a review from doronbehar August 6, 2025 03:49
@doronbehar
Copy link
Copy Markdown
Contributor

doronbehar commented Aug 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 418244
Commit: 7ee186359f28dc1a5d98eabd070630366d467cc4

x86_64-linux

✅ 1 package built:
  • ld-audit-search-mod

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 6, 2025
@doronbehar
Copy link
Copy Markdown
Contributor

doronbehar commented Aug 6, 2025

While reading:

I encountered also:

Which made me feel like I am a complete noob on these subjects. Still though, this PR seems very simple and legitimate, and it should be compatible even if we'd decide to perform a change to binutils / glibc.

I also think it shouldn't be a problem to see the NixOS module added here too. One thing that was weird for me in upstream's README is this:

@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Aug 7, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2502

@Ma27 Ma27 merged commit ddbe450 into NixOS:master Aug 7, 2025
26 of 28 checks passed
@Atry Atry deleted the ld-audit-search-mod branch August 7, 2025 17:33
@Atry Atry mentioned this pull request Aug 8, 2025
Draft
13 tasks
@Atry Atry mentioned this pull request Aug 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doronbehar doronbehar doronbehar approved these changes

@SomeoneSerge SomeoneSerge Awaiting requested review from SomeoneSerge

@thufschmitt thufschmitt Awaiting requested review from thufschmitt

@oxij oxij Awaiting requested review from oxij

@pennae pennae Awaiting requested review from pennae

@copumpkin copumpkin Awaiting requested review from copumpkin

@timokau timokau Awaiting requested review from timokau

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

@Ma27 Ma27 Awaiting requested review from Ma27

+1 more reviewer

@DDoSolitary DDoSolitary DDoSolitary left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Atry @doronbehar @nixos-discourse @Ma27 @DDoSolitary