Skip to content

nixos/tests/gnome3: switch to lightdm#41742

Merged
xeji merged 1 commit intoNixOS:masterfrom
xeji:gnome3-test-lightdm
Jun 9, 2018
Merged

nixos/tests/gnome3: switch to lightdm#41742
xeji merged 1 commit intoNixOS:masterfrom
xeji:gnome3-test-lightdm

Conversation

@xeji
Copy link
Copy Markdown
Contributor

@xeji xeji commented Jun 9, 2018

Motivation for this change

#41616. The test failed because the the slim display manager doesn't start the gnome3 session correctly. Switch it to lightdm. (slim is unmaintained since 2014 and shouldn't be the default anymore, see #30890. For gdm we already have a separate test gnome3-gdm.)

/cc @jtojnar and listed maintainers @domenkozar @eelco @chaoflow @lethalman

Things done

Test succeeds on local machine.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jun 9, 2018
@xeji xeji mentioned this pull request Jun 9, 2018
Closed
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 9, 2018
jtojnar
jtojnar approved these changes Jun 9, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unable to test but lgtm

@jtojnar
Copy link
Copy Markdown
Member

jtojnar commented Jun 9, 2018

@GrahamcOfBorg test gnome3

@GrahamcOfBorg
Copy link
Copy Markdown

GrahamcOfBorg commented Jun 9, 2018

Failure on x86_64-linux (full log)

Attempted: tests.gnome3

Partial log (click to expand)

cannot build derivation '/nix/store/8cvz1dbinqhcs26vcphdahhhn2zdbw6q-system-units.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/6ikgs3hx44p3n291c99mnd885jz75fa8-user-units.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/qivxwqxrx2gily9l4x2xdhvg43q3zgyg-etc.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/nlvz6mwr9jkgvi4k3kapw27pahz598sx-nixos-system-machine-18.09.git.76b9520.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/x4319fs2ahym309y630jpmkq60lkmy7d-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mzs8q3zg98ghqwki5rzjs55sf07yhahq-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/y74ri07x78m4a650x1hm9ak28d704rp3-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/0br80n9k8az61la8chnq5w9vyxxhj65a-nixos-test-driver-gnome3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/saw0fygqx438gggr2m7jg6v2agb5va2q-vm-test-run-gnome3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/saw0fygqx438gggr2m7jg6v2agb5va2q-vm-test-run-gnome3.drv' failed

@xeji
Copy link
Copy Markdown
Contributor Author

xeji commented Jun 9, 2018 via email

@GrahamcOfBorg
Copy link
Copy Markdown

GrahamcOfBorg commented Jun 9, 2018

Failure on aarch64-linux (full log)

Attempted: tests.gnome3

Partial log (click to expand)

cannot build derivation '/nix/store/v1xcxglvxzggmp09g6zl6dl8h213i69c-system-units.drv': 16 dependencies couldn't be built
cannot build derivation '/nix/store/hi0khvrpaz39p9ac2yl73as28r8z8gxq-user-units.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/ci4k1rab96g2da35qdlkaazwlm3v1yhg-etc.drv': 14 dependencies couldn't be built
cannot build derivation '/nix/store/46ah8j6j6nazf7w65amgsih0jkfj4vi4-nixos-system-machine-18.09.git.c446c25.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/zdg2p1vl9cpvbmbc57j1vv9957vf7lx4-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/f3m0fiml9whl9ylw26b542nciccvnwwl-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/awsm3ql9af067nb9vd0cfh387ypi53h1-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/phfdqixi639dhr3zcp1zxpfzm9nsp7nd-nixos-test-driver-gnome3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/fv97268wr1nw0njlw74nlfvmn0ypzm7f-vm-test-run-gnome3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/fv97268wr1nw0njlw74nlfvmn0ypzm7f-vm-test-run-gnome3.drv' failed

@jtojnar
Copy link
Copy Markdown
Member

jtojnar commented Jun 9, 2018

@GrahamcOfBorg test gnome3

@GrahamcOfBorg
Copy link
Copy Markdown

GrahamcOfBorg commented Jun 9, 2018

Success on x86_64-linux (full log)

Attempted: tests.gnome3

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 50.35s
cleaning up
killing machine (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/q5krfrgbsksibig9i3knasl9kzbm2xxm-vm-test-run-gnome3

@GrahamcOfBorg
Copy link
Copy Markdown

GrahamcOfBorg commented Jun 9, 2018

Failure on aarch64-linux (full log)

Attempted: tests.gnome3

Partial log (click to expand)

cannot build derivation '/nix/store/rxn5s8vhff14i497vfpzadankpvy2qsg-system-units.drv': 16 dependencies couldn't be built
cannot build derivation '/nix/store/67rsmhbm7k28qf6y83aqa5c0mzm5hva8-user-units.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/0hpj8jbxyzsxk8gfx1r02ffnwyfgqxwp-etc.drv': 14 dependencies couldn't be built
cannot build derivation '/nix/store/pgli8zg04ajr8xn1dkbj068nb0b16sqg-nixos-system-machine-18.09.git.c248103.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/aq7y5b2qdx1cbsd1gbrjgf1v5rpk9c86-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/yjvmwsxyhgx0wjddxq0xrqawcv5as586-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/9zc90lbp0rfg0jymnrc5lwv7afxysikp-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/idzs8g1b7rlgaq61y82wzmrlhf2b82iq-nixos-test-driver-gnome3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/f3bfj44c04yx10r357i2lgxfni7g9hb7-vm-test-run-gnome3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/f3bfj44c04yx10r357i2lgxfni7g9hb7-vm-test-run-gnome3.drv' failed

@xeji xeji merged commit 08197d0 into NixOS:master Jun 9, 2018
@xeji xeji deleted the gnome3-test-lightdm branch June 9, 2018 20:02
@Lassulus Lassulus mentioned this pull request Aug 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xeji @jtojnar @GrahamcOfBorg