Skip to content

sdl3: 3.2.14 -> 3.2.16#414169

Merged
pbsds merged 1 commit intoNixOS:stagingfrom
LordGrimmauld:sdl3-up
Jun 5, 2025
Merged

sdl3: 3.2.14 -> 3.2.16#414169
pbsds merged 1 commit intoNixOS:stagingfrom
LordGrimmauld:sdl3-up

Conversation

@LordGrimmauld
Copy link
Copy Markdown
Contributor

@LordGrimmauld LordGrimmauld commented Jun 5, 2025

Release notes: https://github.com/libsdl-org/SDL/releases/tag/release-3.2.16
Diff: libsdl-org/SDL@release-3.2.14...release-3.2.16

Mostly bugfixes, most of which only relevant for windows, xbox or android.

Some details about (linux) audio changed, specifically how device leases work. ffplay still plays audio just fine, so nothing seems broken.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@LordGrimmauld
sdl3: 3.2.14 -> 3.2.16
7219e88 
Release notes: https://github.com/libsdl-org/SDL/releases/tag/release-3.2.16
Diff: libsdl-org/SDL@release-3.2.14...release-3.2.16

Mostly bugfixes, most of which only relevant for windows, xbox or android.

Some details about (linux) audio changed, specifically how device leases work.
`ffplay` still plays audio just fine, so nothing seems broken.
@LordGrimmauld
Copy link
Copy Markdown
Contributor Author

LordGrimmauld commented Jun 5, 2025 •
edited
Loading

Because of android changes i wanted to build pkgsCross.aarch64-android.sdl3, but that is broken very deep down at elfutils and compiler-rt, so i won't bother.

@github-actions github-actions bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Jun 5, 2025
marcin-serwin
marcin-serwin approved these changes Jun 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@marcin-serwin marcin-serwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff lgtm

@pbsds
Copy link
Copy Markdown
Member

pbsds commented Jun 5, 2025

builds when cherry-picked on master

@pbsds pbsds merged commit 7846763 into NixOS:staging Jun 5, 2025
15 of 18 checks passed
@getchoo getchoo mentioned this pull request Jul 15, 2025
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcin-serwin marcin-serwin marcin-serwin approved these changes

@getchoo getchoo Awaiting requested review from getchoo

@jansol jansol Awaiting requested review from jansol

@evysgarden evysgarden Awaiting requested review from evysgarden

@pbsds pbsds Awaiting requested review from pbsds

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LordGrimmauld @pbsds @marcin-serwin