octodns: python3Packages.callPackage -> callPackage, octodns-providers.*: autocall using octodns' python#402602
Merged
mweinelt merged 2 commits intoNixOS:masterfrom Apr 29, 2025
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
mweinelt
reviewed
Apr 28, 2025
mweinelt
reviewed
Apr 28, 2025
2ec184d to
4f00ceb
Compare
mweinelt
reviewed
Apr 28, 2025
mweinelt
reviewed
Apr 28, 2025
mweinelt
reviewed
Apr 28, 2025
4f00ceb to
639c14d
Compare
Member
autocalling 😉 |
Contributor
Author
|
639c14d to
7e92ae3
Compare
mweinelt
approved these changes
Apr 28, 2025
Member
mweinelt
left a comment
There was a problem hiding this comment.
Thanks, that looks much better now!
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.