Skip to content

xrootd: 5.7.1 -> 5.8.0 #397667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GaetanLepage merged 1 commit into from
Apr 11, 2025
Merged

xrootd: 5.7.1 -> 5.8.0 #397667

GaetanLepage merged 1 commit into from
Apr 11, 2025

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Apr 10, 2025 •
edited
Loading

Things done

Diff: xrootd/xrootd@refs/tags/v5.7.1...refs/tags/v5.8.0
Changelog: https://github.com/xrootd/xrootd/releases/tag/v5.8.0

cc @ShamrockLee

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 10, 2025
@nix-owners nix-owners bot requested a review from ShamrockLee April 10, 2025 12:53
@ShamrockLee
Copy link
Contributor

ShamrockLee commented Apr 10, 2025

xrootd fail to build in OfBorg after update.

The search function of NixOS Hydra returns 500 error, so I cannot check if xrootd builds before the change.

@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Apr 10, 2025 •
edited
Loading

The build is failing in fixupPhase with:

Moving /nix/store/3zw12avd4c3h07a0rpl35jvqhv0gfx6l-xrootd-5.8.0-bin/bin/xrootd-config to /nix/store/6vnmipw8p1hc6cmkrsq9v1ay7j6iycq2-xrootd-5.8.0-dev/bin/xrootd-config
Running phase: fixupPhase
@nix { "action": "setPhase", "phase": "fixupPhase" }
Moving /nix/store/jbh4667k5zm74h9wv8y1j11x89cv6pnd-xrootd-5.8.0/include to /nix/store/6vnmipw8p1hc6cmkrsq9v1ay7j6iycq2-xrootd-5.8.0-dev/include
mv: cannot overwrite '/nix/store/6vnmipw8p1hc6cmkrsq9v1ay7j6iycq2-xrootd-5.8.0-dev/include/xrootd': Directory not empty

I bisected it to xrootd/xrootd@9387f64.
I suspect that it is related to xrootd/xrootd@9387f64#diff-7b25d5f1cdc3ff8d39ffeb84e4285b93dcdce7bb4ed29217eed6d2702b26994dR107-R120

@GaetanLepage GaetanLepage mentioned this pull request Apr 10, 2025
Merged
@ShamrockLee
Copy link
Contributor

ShamrockLee commented Apr 11, 2025

@ofborg build gfal2-util.tests
@ofborg build root

@ShamrockLee
Copy link
Contributor

ShamrockLee commented Apr 11, 2025

The functionality tests are automated. It's save to merge if xrootd.tests, gfal2-util.tests and root all build successfully.

@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Apr 11, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 397667 --package gfal2-util.tests --package xrootd.tests --package root

x86_64-linux

✅ 6 packages built:
  • gfal2-util.tests.test-copy-dir-xrootd
  • gfal2-util.tests.test-copy-file-xrootd
  • gfal2-util.tests.test-ls-dir-xrootd
  • root
  • root.debug (root.debug.debug)
  • xrootd.tests.test-xrdcp

aarch64-linux

✅ 6 packages built:
  • gfal2-util.tests.test-copy-dir-xrootd
  • gfal2-util.tests.test-copy-file-xrootd
  • gfal2-util.tests.test-ls-dir-xrootd
  • root
  • root.debug (root.debug.debug)
  • xrootd.tests.test-xrdcp

x86_64-darwin

✅ 5 packages built:
  • gfal2-util.tests.test-copy-dir-xrootd
  • gfal2-util.tests.test-copy-file-xrootd
  • gfal2-util.tests.test-ls-dir-xrootd
  • root
  • xrootd.tests.test-xrdcp

aarch64-darwin

✅ 5 packages built:
  • gfal2-util.tests.test-copy-dir-xrootd
  • gfal2-util.tests.test-copy-file-xrootd
  • gfal2-util.tests.test-ls-dir-xrootd
  • root
  • xrootd.tests.test-xrdcp

@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Apr 11, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 397667

x86_64-linux

⏩ 8 packages marked as broken and skipped:
  • python312Packages.gfal2-python
  • python312Packages.gfal2-python.dist
  • python312Packages.gfal2-util
  • python312Packages.gfal2-util.dist
  • python313Packages.gfal2-python
  • python313Packages.gfal2-python.dist
  • python313Packages.gfal2-util
  • python313Packages.gfal2-util.dist
✅ 36 packages built:
  • gfal2
  • gfal2-util
  • gfal2-util.dist
  • hepmc3
  • herwig
  • ns-3
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python312Packages.fsspec-xrootd
  • python312Packages.fsspec-xrootd.dist
  • python312Packages.hepmc3
  • rivet (python312Packages.rivet)
  • python312Packages.snakemake-storage-plugin-xrootd
  • python312Packages.snakemake-storage-plugin-xrootd.dist
  • python312Packages.xrootd
  • python312Packages.xrootd.dist
  • python313Packages.coffea
  • python313Packages.coffea.dist
  • python313Packages.fsspec-xrootd
  • python313Packages.fsspec-xrootd.dist
  • python313Packages.hepmc3
  • python313Packages.rivet
  • python313Packages.snakemake-storage-plugin-xrootd
  • python313Packages.snakemake-storage-plugin-xrootd.dist
  • python313Packages.xrootd
  • python313Packages.xrootd.dist
  • root
  • root.debug
  • thepeg
  • xfitter
  • xrootd
  • xrootd.bin
  • xrootd.dev
  • xrootd.etc
  • xrootd.man
  • yoda-with-root

aarch64-linux

⏩ 10 packages marked as broken and skipped:
  • herwig
  • ns-3
  • python312Packages.gfal2-python
  • python312Packages.gfal2-python.dist
  • python312Packages.gfal2-util
  • python312Packages.gfal2-util.dist
  • python313Packages.gfal2-python
  • python313Packages.gfal2-python.dist
  • python313Packages.gfal2-util
  • python313Packages.gfal2-util.dist
✅ 34 packages built:
  • gfal2
  • gfal2-util
  • gfal2-util.dist
  • hepmc3
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python312Packages.fsspec-xrootd
  • python312Packages.fsspec-xrootd.dist
  • python312Packages.hepmc3
  • rivet (python312Packages.rivet)
  • python312Packages.snakemake-storage-plugin-xrootd
  • python312Packages.snakemake-storage-plugin-xrootd.dist
  • python312Packages.xrootd
  • python312Packages.xrootd.dist
  • python313Packages.coffea
  • python313Packages.coffea.dist
  • python313Packages.fsspec-xrootd
  • python313Packages.fsspec-xrootd.dist
  • python313Packages.hepmc3
  • python313Packages.rivet
  • python313Packages.snakemake-storage-plugin-xrootd
  • python313Packages.snakemake-storage-plugin-xrootd.dist
  • python313Packages.xrootd
  • python313Packages.xrootd.dist
  • root
  • root.debug
  • thepeg
  • xfitter
  • xrootd
  • xrootd.bin
  • xrootd.dev
  • xrootd.etc
  • xrootd.man
  • yoda-with-root

x86_64-darwin

⏩ 10 packages marked as broken and skipped:
  • herwig
  • python312Packages.gfal2-python
  • python312Packages.gfal2-python.dist
  • python312Packages.gfal2-util
  • python312Packages.gfal2-util.dist
  • python313Packages.gfal2-python
  • python313Packages.gfal2-python.dist
  • python313Packages.gfal2-util
  • python313Packages.gfal2-util.dist
  • thepeg
✅ 33 packages built:
  • gfal2
  • gfal2-util
  • gfal2-util.dist
  • hepmc3
  • ns-3
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python312Packages.fsspec-xrootd
  • python312Packages.fsspec-xrootd.dist
  • python312Packages.hepmc3
  • rivet (python312Packages.rivet)
  • python312Packages.snakemake-storage-plugin-xrootd
  • python312Packages.snakemake-storage-plugin-xrootd.dist
  • python312Packages.xrootd
  • python312Packages.xrootd.dist
  • python313Packages.coffea
  • python313Packages.coffea.dist
  • python313Packages.fsspec-xrootd
  • python313Packages.fsspec-xrootd.dist
  • python313Packages.hepmc3
  • python313Packages.rivet
  • python313Packages.snakemake-storage-plugin-xrootd
  • python313Packages.snakemake-storage-plugin-xrootd.dist
  • python313Packages.xrootd
  • python313Packages.xrootd.dist
  • root
  • xfitter
  • xrootd
  • xrootd.bin
  • xrootd.dev
  • xrootd.etc
  • xrootd.man
  • yoda-with-root

aarch64-darwin

⏩ 11 packages marked as broken and skipped:
  • herwig
  • ns-3
  • python312Packages.gfal2-python
  • python312Packages.gfal2-python.dist
  • python312Packages.gfal2-util
  • python312Packages.gfal2-util.dist
  • python313Packages.gfal2-python
  • python313Packages.gfal2-python.dist
  • python313Packages.gfal2-util
  • python313Packages.gfal2-util.dist
  • thepeg
✅ 32 packages built:
  • gfal2
  • gfal2-util
  • gfal2-util.dist
  • hepmc3
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python312Packages.fsspec-xrootd
  • python312Packages.fsspec-xrootd.dist
  • python312Packages.hepmc3
  • rivet (python312Packages.rivet)
  • python312Packages.snakemake-storage-plugin-xrootd
  • python312Packages.snakemake-storage-plugin-xrootd.dist
  • python312Packages.xrootd
  • python312Packages.xrootd.dist
  • python313Packages.coffea
  • python313Packages.coffea.dist
  • python313Packages.fsspec-xrootd
  • python313Packages.fsspec-xrootd.dist
  • python313Packages.hepmc3
  • python313Packages.rivet
  • python313Packages.snakemake-storage-plugin-xrootd
  • python313Packages.snakemake-storage-plugin-xrootd.dist
  • python313Packages.xrootd
  • python313Packages.xrootd.dist
  • root
  • xfitter
  • xrootd
  • xrootd.bin
  • xrootd.dev
  • xrootd.etc
  • xrootd.man
  • yoda-with-root

@GaetanLepage GaetanLepage merged commit 9312209 into NixOS:master Apr 11, 2025
76 of 83 checks passed
@GaetanLepage GaetanLepage deleted the xrootd branch April 11, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShamrockLee ShamrockLee ShamrockLee approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GaetanLepage @ShamrockLee