nixos/cosmic-greeter: init; nixos/cosmic: init by thefossguy · Pull Request #392837 · NixOS/nixpkgs

thefossguy · 2025-03-24T19:52:08Z

Initialize the cosmic modules so the state of broken-ness (or not) of any packages in nixpkgs can be tested.

This will help test the packages and bring out bugs like following:

Mar 25 01:18:22 matsya cosmic-session[1923]: thread 'main' panicked at 'failed to start cosmic-idle': src/main.rs:560
[---snip---]
Mar 25 01:18:23 matsya .cosmic-comp-wrapped[2045]: Unable to parse your locale: ParserError(InvalidLanguage)
Mar 25 01:18:23 matsya .cosmic-comp-wrapped[2045]: Failed to read config 'workspaces'
[---snip---]
Mar 25 01:18:23 matsya .cosmic-comp-wrapped[2045]: shortcuts custom config error: GetKey("custom", Os { code: 2, kind: NotFound, message: "No such file or directory" })

Closes #369113.

Things done

Add a 👍 reaction to pull requests you find important.

thefossguy · 2025-03-24T19:53:21Z

Closes #369113.

nrabulinski · 2025-03-24T20:27:39Z

If you're copying @lilyinstarlight's work verbatim, at least have the dignity of adding a Co-authored-by

nixos/modules/services/desktop-managers/cosmic.nix

nixos/modules/services/display-managers/cosmic-greeter.nix

nyabinary

The PR title should probably be named as nixos/cosmic-greeter: init; nixos/cosmic: init
Furthermore, please credit @lilyinstarlight as many others have said :P

thefossguy · 2025-03-25T04:08:32Z

If you're copying @lilyinstarlight's work verbatim, at least have the dignity of adding a Co-authored-by

You don't need to attack anyone to get your point across. Could have mentioned the same thing without assuming I'm a bad guy. My libcosmicAppHook PR was the first to attribute Lily so don't paint me as a bad guy. The earlier PRs from me did not attribute Lily because I'm not at all familiar with software copyrights and didn't know how to do it properly. I asked Lily how the "header" should look like and it resulted in this.

I woke up and the first thing I read about this PR is ~~feedback in form of accusation~~ some good ol' character assassination. :/
I might be an idiot in but I'm not a malicious actor.

thefossguy · 2025-03-25T04:23:52Z

@HeitorAugustoLN @nyabinary added comments attributing code to Lily and added an option in the cosmic-greeter and cosmic modules to configure the greeter package used.

ahoneybun · 2025-03-25T17:21:08Z

@ALL let's take a step back on the replies about the lack of credit to Lily a little bit. It is possible that @thefossguy just forgot to add it in this PR which is a simple mistake.

@thefossguy since the credit was added for this PR I think everyone expected it to also be included in this PR as well which caused the reaction.

nixos/modules/services/desktop-managers/cosmic.nix

nixos/modules/services/display-managers/cosmic-greeter.nix

nixos/modules/services/desktop-managers/cosmic.nix

thefossguy · 2025-03-25T18:29:02Z

Resolved a few suggestions which I have made modifications for locally. Waiting on the documentation one for clarification so I can push.

nixos/modules/services/desktop-managers/cosmic.nix

thefossguy · 2025-03-25T20:04:05Z

Pushed with all requested changes addressed.

nyabinary · 2025-03-26T02:01:14Z

Can I also be added as a maintainer btw? :3

thefossguy · 2025-03-26T04:52:27Z

@nyabinary done :)

thefossguy · 2025-03-30T09:09:49Z

Making sure my changes incorporating services.graphical-desktop.enable doesn't break anything.

thefossguy · 2025-03-30T10:19:17Z

Final push addresses almost all review comments. Please let me know if I missed anything.

nixos/doc/manual/release-notes/rl-2505.section.md

nixos/modules/services/desktop-managers/cosmic.nix

thefossguy · 2025-03-30T19:07:14Z

Pushed commits addressing the recent reviews. Let me know if I missed anything.

GaetanLepage

Diff LGTM.
Good job everyone!

JohnRTitor · 2025-03-31T09:58:35Z

Merging, we do want some NixOS tests though, at some point, once it gets stable enough.

sebastianrasor · 2025-04-01T05:48:26Z

https://github.com/thefossguy/nixpkgs/blob/a793ee3962cf3be3d0e9ed1022147ea9cd34eea9/nixos/modules/services/desktop-managers/cosmic.nix#L131-L140

I don't think these "good to have defaults" should be included. For example, Avahi adds nearly a whole watt of idle usage to my system. I think it should be up to end-users to explicitly enable each of these "good to have" options if they'd like to have them enabled, rather than choosing to enable it for them because you think they're "good to have."

JohnRTitor · 2025-04-01T06:10:57Z

These options are there (in also Cinnamon, Pantheon, Mate), so most features out of the box works properly for everybody.

These are marked with mkDefault, feel free to set them to false.

lilyinstarlight

Apologies I've been sick and unable to even look at this until now

I'm a bit disappointed that helpful comments were removed when this was copy-pasted from the upstream repository, some required code was not copied, and some home-manager-kludge code was mistakenly copied despite the (removed) comment. I would have probably answered questions if something was unclear, but this was done entirely without contact or coordination

lilyinstarlight · 2025-04-01T18:20:22Z

nixos/modules/services/desktop-managers/cosmic.nix

+        tray = {
+          description = "Cosmic Tray Target";
+          requires = [ "graphical-session-pre.target" ];
+        };
+      };


This is a home-manager concern and not a nixpkgs concern and has no business in the nixpkgs repository (which would have been more obvious if the comments weren't removed when copy-pasting)

As the original comment also stated, this was a temporary kludge for home-manager 24.11 which did not have nix-community/home-manager#6332, so this is even extra unnecessary on unstable

lilyinstarlight · 2025-04-01T18:21:15Z

nixos/modules/services/desktop-managers/cosmic.nix

+    services.displayManager.sessionPackages = [ pkgs.cosmic-session ];
+    services.libinput.enable = true;
+    services.upower.enable = true;
+    # Setup PAM authentication for the `cosmic-greeter` user


This comment is incorrect. This has nothing to do with the cosmic-greeter user and is for screenlocking, as the original comment stated (idk why this comment was changed when this was copied)

lilyinstarlight · 2025-04-01T18:26:18Z

nixos/modules/services/display-managers/cosmic-greeter.nix

+      createHome = true;
+      group = "cosmic-greeter";
+    };
+    # Setup PAM authentication for the `cosmic-greeter` user


Again this has nothing to do with the cosmic-greeter user and idk why this comment was changed when copy-pasting

This is the name of the PAM service that cosmic-greeter uses and so we must configure the service to be present (the PAM NixOS module handles most of the configuration as the user specifies elsewhere, we just provide the name here and have it handle the rest as cosmic-greeter has no special requirements)

JohnRTitor · 2025-04-03T12:25:18Z

~~Could you address the new review comments in another PR?~~

EDIT: I see that the fix has been merged already, thanks GaetanLeepage

github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 24, 2025

thefossguy requested review from a-kenji, ahoneybun and nyabinary March 24, 2025 19:55

github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 24, 2025

h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Mar 24, 2025

HeitorAugustoLN requested changes Mar 24, 2025

View reviewed changes

nyabinary reviewed Mar 24, 2025

View reviewed changes

thefossguy changed the title ~~Initialize cosmic modules~~ nixos/cosmic-greeter: init; nixos/cosmic: init Mar 25, 2025

thefossguy force-pushed the cosmic-modules-init branch 2 times, most recently from 023e0d2 to c07693c Compare March 25, 2025 04:21

thefossguy requested review from HeitorAugustoLN and nyabinary March 25, 2025 04:23

HeitorAugustoLN requested changes Mar 25, 2025

View reviewed changes

HeitorAugustoLN reviewed Mar 25, 2025

View reviewed changes

nixos/modules/services/desktop-managers/cosmic.nix Outdated Show resolved Hide resolved

thefossguy force-pushed the cosmic-modules-init branch from c07693c to 7750fd6 Compare March 25, 2025 20:03

thefossguy force-pushed the cosmic-modules-init branch from 7750fd6 to d5e6420 Compare March 25, 2025 20:06

thefossguy force-pushed the cosmic-modules-init branch from d5e6420 to 6a752cc Compare March 26, 2025 04:52

thefossguy force-pushed the cosmic-modules-init branch from 6a752cc to f2d3271 Compare March 26, 2025 06:06

thefossguy marked this pull request as draft March 30, 2025 09:10

nixos/modules: cosmic-greeter: init

307b5c7

thefossguy force-pushed the cosmic-modules-init branch from 652e3e2 to 68701d5 Compare March 30, 2025 10:02

thefossguy marked this pull request as ready for review March 30, 2025 10:03

github-actions bot added 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation labels Mar 30, 2025

thefossguy requested a review from JohnRTitor March 30, 2025 10:19

JohnRTitor reviewed Mar 30, 2025

View reviewed changes

nixos/doc/manual/release-notes/rl-2505.section.md Outdated Show resolved Hide resolved

JohnRTitor reviewed Mar 30, 2025

View reviewed changes

nixos/modules/services/desktop-managers/cosmic.nix Outdated Show resolved Hide resolved

JohnRTitor reviewed Mar 30, 2025

View reviewed changes

nixos/modules/services/desktop-managers/cosmic.nix Outdated Show resolved Hide resolved

JohnRTitor reviewed Mar 30, 2025

View reviewed changes

nixos/modules/services/desktop-managers/cosmic.nix Outdated Show resolved Hide resolved

thefossguy added 2 commits March 31, 2025 00:30

nixos/modules: cosmic: init

14d55c1

nixos/release-notes: add release notes for COSMIC modules

64ce112

thefossguy force-pushed the cosmic-modules-init branch from 0b0e4fe to 64ce112 Compare March 30, 2025 19:06

JohnRTitor approved these changes Mar 31, 2025

View reviewed changes

GaetanLepage approved these changes Mar 31, 2025

View reviewed changes

JohnRTitor merged commit 2a7180b into NixOS:master Mar 31, 2025
33 of 35 checks passed

cramt mentioned this pull request Mar 31, 2025

cosmic: add target nix-community/stylix#265

Open

JohnRTitor mentioned this pull request Mar 26, 2025

Tracking: COSMIC Desktop Environment #259641

Open

33 tasks

JohnRTitor mentioned this pull request Apr 1, 2025

[Super WIP] cosmic desktop environment #344397

Closed

13 tasks

lilyinstarlight reviewed Apr 1, 2025

View reviewed changes

GaetanLepage mentioned this pull request Apr 2, 2025

nixos/cosmic[-greeter]: minor corrections #395521

Merged

13 tasks

JohnRTitor mentioned this pull request Apr 19, 2025

nixos/cosmic: a way to exclude packages #399993

Closed

Uh oh!

Conversation

thefossguy commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

thefossguy commented Mar 24, 2025

Uh oh!

nrabulinski commented Mar 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nyabinary left a comment

Choose a reason for hiding this comment

Uh oh!

thefossguy commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thefossguy commented Mar 25, 2025

Uh oh!

ahoneybun commented Mar 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thefossguy commented Mar 25, 2025

Uh oh!

Uh oh!

thefossguy commented Mar 25, 2025

Uh oh!

nyabinary commented Mar 26, 2025

Uh oh!

thefossguy commented Mar 26, 2025

Uh oh!

thefossguy commented Mar 30, 2025

Uh oh!

thefossguy commented Mar 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thefossguy commented Mar 30, 2025

Uh oh!

GaetanLepage left a comment

Choose a reason for hiding this comment

Uh oh!

JohnRTitor commented Mar 31, 2025

Uh oh!

Uh oh!

sebastianrasor commented Apr 1, 2025

Uh oh!

JohnRTitor commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lilyinstarlight left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lilyinstarlight Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

lilyinstarlight Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

lilyinstarlight Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

JohnRTitor commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

thefossguy commented Mar 24, 2025 •

edited

Loading

thefossguy commented Mar 25, 2025 •

edited

Loading

JohnRTitor commented Apr 1, 2025 •

edited

Loading

lilyinstarlight left a comment •

edited

Loading

JohnRTitor commented Apr 3, 2025 •

edited

Loading