buildVscodeExtension: support finalAttrs through lib.extendMkDerivation#390180
Merged
philiptaron merged 3 commits intoNixOS:masterfrom Mar 18, 2025
Merged
buildVscodeExtension: support finalAttrs through lib.extendMkDerivation#390180philiptaron merged 3 commits intoNixOS:masterfrom
finalAttrs through lib.extendMkDerivation#390180philiptaron merged 3 commits intoNixOS:masterfrom
Conversation
0313e4a to
06b1e4a
Compare
06b1e4a to
5c21285
Compare
5c21285 to
c87ef3e
Compare
drupol
commented
Mar 15, 2025
16f43cc to
2c1a7d6
Compare
philiptaron
previously approved these changes
Mar 16, 2025
Contributor
|
I'm interested in why the rebuild count is what is it. |
753507e to
52f7f23
Compare
Gotta actually build everything first before just trusting the old eyeballs.
Contributor
|
Contributor
Author
|
I just found out the issue. Give me 2 min to fix it. |
Contributor
Sounds good. I'm stepping out to enjoy the sunshine and spring weather, so take your time. |
52f7f23 to
7e022a6
Compare
Contributor
Author
Send some over here :) |
Contributor
|
Contributor
Author
I can successfully build these 2 extensions, I guess the issue is not related to this PR. |
Contributor
Author
|
@philiptaron Doth this suffice for merging? |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-390180-to-release-24.11 origin/release-24.11
cd .worktree/backport-390180-to-release-24.11
git switch --create backport-390180-to-release-24.11
git cherry-pick -x f0f9bdd5774e1f163d1d6f8d9aa7ecb90332ccac 82d30e0d4fb1275fc148498eaafe42bc04966733 7e022a68d457d9ece55c65b0b755c9e0eec491c6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired from #382550.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.