opam-repository: remove broken/unnecessary patch#388471
Merged
vbgl merged 1 commit intoNixOS:masterfrom Mar 13, 2025
Merged
Conversation
Member
|
Looks like this has been here since the beginning, maybe @sternenseemann or @vbgl has some insight into why it was added like this? I assume what we want to do is to replace |
Contributor
|
I have no clue why this patch is there. |
Contributor
Author
|
is there anything i can do to get this merged by any chance? |
Contributor
|
Your message was the thing to be done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch breaks the
opam-publishpackage on nixpkgs. I'm not sure why it was ever necessary but it breaks the invariants of the library and would've never worked for its intended purpose anyway:CIdentis a value indicating a variable, not a constant so it will be replaced with an empty string when the new/nix/store/wq37ah6ayglskxv1viw204j246miz9mw-curl-8.11.0-bin/bin/curlvalue isn't recognized. For this reasonopam-publishcurrently fails with: