Skip to content

phpPackages.psalm: 6.5.0 -> 6.8.6#384574

Merged
drupol merged 1 commit intoNixOS:masterfrom
drupol:push-ntvmvysqnvmk
Feb 23, 2025
Merged

phpPackages.psalm: 6.5.0 -> 6.8.6#384574
drupol merged 1 commit intoNixOS:masterfrom
drupol:push-ntvmvysqnvmk

Conversation

@drupol
Copy link
Contributor

@drupol drupol commented Feb 23, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: php PHP is a general-purpose scripting language geared towards web development. label Feb 23, 2025
@nix-owners nix-owners bot requested review from Ma27, aanderse, globin and talyz February 23, 2025 18:24
@drupol drupol mentioned this pull request Feb 23, 2025
Merged
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 23, 2025
@nix-owners nix-owners bot requested a review from piotrkwiecinski February 23, 2025 18:30
@piotrkwiecinski
Copy link
Contributor

piotrkwiecinski commented Feb 23, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 384574

x86_64-linux

❌ 1 package failed to build:
  • php81Packages.psalm
✅ 3 packages built:
  • php82Packages.psalm
  • php83Packages.psalm
  • php84Packages.psalm

@piotrkwiecinski
Copy link
Contributor

piotrkwiecinski commented Feb 23, 2025 •
edited
Loading

If I'm not mistaken the error comes from composer itself. PHP 8.1 support requires composer LTS(2.2.X).

@drupol
Copy link
Contributor Author

drupol commented Feb 23, 2025

The embedded composer.lock has been created using PHP 8.2, this is why we can't build PSalm with PHP 8.1.

drupol referenced this pull request in vimeo/psalm Feb 23, 2025
@danog
Fixes
15731ea
@piotrkwiecinski
Copy link
Contributor

piotrkwiecinski commented Feb 23, 2025

Do we even need multiple versions? Maybe we could just move it to by-name like phpunit?

@drupol
Copy link
Contributor Author

drupol commented Feb 23, 2025

Do we even need multiple versions? Maybe we could just move it to by-name like phpunit?

I would then ask the @NixOS/php team for this decision as it might have a bigger impact.

@piotrkwiecinski
Copy link
Contributor

piotrkwiecinski commented Feb 23, 2025

If not could we at least mark it as broken on 8.1?

@drupol
Copy link
Contributor Author

drupol commented Feb 23, 2025

yes, going to mark it as broken for PHP 8.1.

@drupol
Copy link
Contributor Author

drupol commented Feb 23, 2025

I got the confirmation from @danog (vimeo/psalm@15731ea#r152900744) that building the PHAR with PHP 8.1 is not working due to a bug in Humbug/Box.

Marking it as broken for PHP 8.1 is definitely the way to go then, I don't really want to maintain a custom composer.lock just for PHP 8.1.

@drupol drupol merged commit e068cc2 into NixOS:master Feb 23, 2025
25 of 27 checks passed
@drupol drupol deleted the push-ntvmvysqnvmk branch February 23, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

@aanderse aanderse Awaiting requested review from aanderse

@talyz talyz Awaiting requested review from talyz

@globin globin Awaiting requested review from globin

1 more reviewer

@piotrkwiecinski piotrkwiecinski piotrkwiecinski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: php PHP is a general-purpose scripting language geared towards web development. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drupol @piotrkwiecinski