Skip to content

nixos: Document handleTest deprecation#383870

Merged
roberth merged 1 commit intoNixOS:masterfrom
roberth:doc-nixos-all-tests-handleTest-vs-runTest
Feb 22, 2025
Merged

nixos: Document handleTest deprecation#383870
roberth merged 1 commit intoNixOS:masterfrom
roberth:doc-nixos-all-tests-handleTest-vs-runTest

Conversation

@roberth
Copy link
Copy Markdown
Member

@roberth roberth commented Feb 21, 2025

Contributor documentation in response to a question by @mweinelt

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@roberth roberth added the 6.topic: documentation Meta-discussion about documentation and its workflow label Feb 21, 2025
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 21, 2025
@r-vdp
Copy link
Copy Markdown
Contributor

r-vdp commented Feb 21, 2025

One other aspect is that with runTest evaluation is considerably more efficient by default. I forgot the exact details, but I think that with handleTest nixpkgs gets re-evaluated several times, whereas with runTest the same evaluation gets re-used.

In the past I moved several big nixos tests over to runTest just to speed up evaluation on my local machine while working on stuff.

@roberth roberth force-pushed the doc-nixos-all-tests-handleTest-vs-runTest branch from 80674ee to 7e3c668 Compare February 21, 2025 11:05
@roberth
Copy link
Copy Markdown
Member Author

roberth commented Feb 21, 2025

@r-vdp Thanks! How could I forget

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 22, 2025
@roberth roberth merged commit 548f59b into NixOS:master Feb 22, 2025
@roberth
Copy link
Copy Markdown
Member Author

roberth commented Mar 3, 2025

Opened a tracking issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: documentation Meta-discussion about documentation and its workflow 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants