Skip to content

python3Packages.pygame-ce: relax meson-python version requirement#380502

Merged
doronbehar merged 1 commit intoNixOS:masterfrom
Rhys-T:fix-pygame-ce
Feb 9, 2025
Merged

python3Packages.pygame-ce: relax meson-python version requirement#380502
doronbehar merged 1 commit intoNixOS:masterfrom
Rhys-T:fix-pygame-ce

Conversation

@Rhys-T
Copy link
Copy Markdown
Contributor

@Rhys-T Rhys-T commented Feb 9, 2025

Needed since python3Packages.meson-python has been updated to 0.17.1.

Resolves #380501.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Needed since python3Packages.meson-python has been updated to 0.17.1.

Resolves NixOS#380501.
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 9, 2025
@Rhys-T Rhys-T marked this pull request as draft February 9, 2025 00:40
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 9, 2025
@nix-owners nix-owners bot requested a review from pbsds February 9, 2025 00:41
@Rhys-T
Copy link
Copy Markdown
Contributor Author

Rhys-T commented Feb 9, 2025

Hmm - it seemed like it was working, but it's actually failing much later in the build for some reason… Reverting to draft until I can figure out what's actually going on.

@Rhys-T
Copy link
Copy Markdown
Contributor Author

Rhys-T commented Feb 9, 2025

Okay, OfBorg seems to have built it successfully with the same drv path. Probably something weird on my end as a result of using nix-user-chroot. I'll set it back to 'ready for review', I guess.

@Rhys-T Rhys-T marked this pull request as ready for review February 9, 2025 00:48
@doronbehar
Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380502


aarch64-darwin

❌ 8 packages failed to build:
  • python312Packages.pygame-ce
  • python312Packages.pygame-ce.dist
  • python312Packages.pygame-gui
  • python312Packages.pygame-gui.dist
  • python313Packages.pygame-ce
  • python313Packages.pygame-ce.dist
  • python313Packages.pygame-gui
  • python313Packages.pygame-gui.dist

@doronbehar
Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380502


x86_64-linux

✅ 8 packages built:
  • python312Packages.pygame-ce
  • python312Packages.pygame-ce.dist
  • python312Packages.pygame-gui
  • python312Packages.pygame-gui.dist
  • python313Packages.pygame-ce
  • python313Packages.pygame-ce.dist
  • python313Packages.pygame-gui
  • python313Packages.pygame-gui.dist

@doronbehar doronbehar merged commit 4c71c99 into NixOS:master Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: pythonPackages.pygame-ce (meson-python dep needs to be relaxed)

2 participants