nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380312

x86_64-linux

Maybe all the cosmic-* packages should be updated to use this hook in this pr or should that be a separate PR?

Maybe all the cosmic-* packages should be updated to use this hook in this pr or should that be a separate PR?

I prefer it in a separate PR, I am planning to do it after this PR is merged.

tbh I don't really get the point of this setup hook because it is unclear what the relevant interface of a "libcosmic app" is. This just looks like a bunch of miscellaneous Cargo stuff that isn't really specific to libcosmic.

tbh I don't really get the point of this setup hook because it is unclear what the relevant interface of a "libcosmic app" is. This just looks like a bunch of miscellaneous Cargo stuff that isn't really specific to libcosmic.

It mostly does some boilerplate required for every libcosmic application, that is mostly wrapping the binary to with dependencies:
https://github.com/NixOS/nixpkgs/blob/38fa1a528eee73108e8631ed2ed3743fe87870f3/pkgs/by-name/co/cosmic-ext-tweaks/package.nix#L63-L65

https://github.com/NixOS/nixpkgs/blob/38fa1a528eee73108e8631ed2ed3743fe87870f3/pkgs/by-name/co/cosmic-ext-tweaks/package.nix#L40-L47

@Ericson2314 This is mostly a wrapper for software that uses the libcosmic library where we are adding a "wrapper" (not really) for X11 and Wayland libraries without duplicating it in the package.nix/default.nix and maybe risk missing some core library.

@HeitorAugustoLN I have the code that uses this apphook ready. Just waiting for this PR to merge. :)

Ah is the problem that since we're talking buildRustPackage not buildRustCrate, we need to apply again and again what is conceptually a single bunch of override for a single library?

In that case, carry on :)

Exactly, yes.

Yes, it originates from nixos-cosmic and I've addressed the authorship in the very beginning of both files. :)

Nothing to test at the moment, it's a setup hook. I will follow up with more PRs in the cosmic-* packages to use the libcosmicAppHook once this PR is merged.

Nothing to test at the moment, it's a setup hook. I will follow up with more PRs in the cosmic-* packages to use the libcosmicAppHook once this PR is merged.

Any plans for the module portion of it as well?

Nothing to test at the moment, it's a setup hook. I will follow up with more PRs in the cosmic-* packages to use the libcosmicAppHook once this PR is merged.

Any plans for the module portion of it as well?

Maybe we should wait for the beta to be released?
Things are still very unstable for now... It might not be a good idea to ship it in nixpkgs. This is nothing more than my opinion.

Nothing to test at the moment, it's a setup hook. I will follow up with more PRs in the cosmic-* packages to use the libcosmicAppHook once this PR is merged.

Any plans for the module portion of it as well?

Maybe we should wait for the beta to be released? Things are still very unstable for now... It might not be a good idea to ship it in nixpkgs. This is nothing more than my opinion.

I don't see why we should stop a module, the packages are already here, maybe we can add a disclaimer in the module description that says it's experimental?

I don't see why we should stop a module, the packages are already here, maybe we can add a disclaimer in the module description that says it's experimental?

I was not saying this for the users, but also, and mostly, for the maintenance.
Deprecating/renaming options can be a little cumbersome.

Having said that, I would have absolutely no objection in merging a PR adding the cosmic module(s).

Nothing to test at the moment, it's a setup hook. I will follow up with more PRs in the cosmic-* packages to use the libcosmicAppHook once this PR is merged.

Any plans for the module portion of it as well?

Yes, I'll reuse the bits (and feedback) from #369113. A bit occupied by work, should send it by the end of this week.

Edit: I plan to upstream just a basic module that simply allows you to enable the greeter + DE and not much else so that should be good enough for testing the state of packages too.

I suggest before adding this hook to cosmic-* packages to write documentation for it in the nixpkgs manual.

I suggest before adding this hook to cosmic-* packages to write documentation for it in the nixpkgs manual.

I added documentation in #386400, as suggested by @a-kenji, can anyone else take a look at it?

Ideally it would be @thefossguy, since they created the PR in the first place.