Skip to content

SDL: propagate X11 libs even when building statically against them on Darwin#36514

Merged
7c6f434c merged 1 commit intoNixOS:masterfrom
oxij:pkgs/fix-pulseaudio-references-fix
Mar 8, 2018
Merged

SDL: propagate X11 libs even when building statically against them on Darwin#36514
7c6f434c merged 1 commit intoNixOS:masterfrom
oxij:pkgs/fix-pulseaudio-references-fix

Conversation

@oxij
Copy link
Copy Markdown
Member

@oxij oxij commented Mar 8, 2018

Packages like SDL_image, SDL_mixer, SDL_net, SDL_ttf depend on this.

This reverts a piece of 19130eb.

Motivation for this change

19130eb#commitcomment-27987219, search "SDL" in https://hydra.nixos.org/jobset/nixpkgs/trunk#tabs-jobs.

Things done

Please run ofborg build SDL SDL_image SDL_mixer SDL_net SDL_ttf on darwin.

@oxij
SDL: propagate X11 libs even when building statically against them on…
2e3077c 
… Darwin

Packages like SDL_image, SDL_mixer, SDL_net, SDL_ttf depend on this.

This reverts a piece of 19130eb.
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Mar 8, 2018
@oxij oxij mentioned this pull request Mar 8, 2018
Merged
5 tasks
oxij referenced this pull request Mar 8, 2018
@oxij
SDL: build statically against x11 on Darwin
19130eb
@7c6f434c
Copy link
Copy Markdown
Member

7c6f434c commented Mar 8, 2018

@GrahamcOfBorg eval

1 similar comment
@ryantm
Copy link
Copy Markdown
Member

ryantm commented Mar 8, 2018

@GrahamcOfBorg eval

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 8, 2018
@GrahamcOfBorg
Copy link
Copy Markdown

GrahamcOfBorg commented Mar 8, 2018

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/p26kggyw4s40cn0180i3519d7pfzlsrw-SDL-1.2.15

@GrahamcOfBorg
Copy link
Copy Markdown

GrahamcOfBorg commented Mar 8, 2018

Success on aarch64-linux (full log)

Partial log (click to expand)

these paths will be fetched (0.13 MiB download, 0.43 MiB unpacked):
  /nix/store/daijpnf7hpc6309lghxj3926vq4a08vm-SDL-1.2.15
copying path '/nix/store/daijpnf7hpc6309lghxj3926vq4a08vm-SDL-1.2.15' from 'https://cache.nixos.org'...
/nix/store/daijpnf7hpc6309lghxj3926vq4a08vm-SDL-1.2.15

@7c6f434c
Copy link
Copy Markdown
Member

7c6f434c commented Mar 8, 2018

@GrahamcOfBorg eval

@7c6f434c
Copy link
Copy Markdown
Member

7c6f434c commented Mar 8, 2018

@GrahamcOfBorg build SDL SDL_image SDL_ttf SDL_mixer

@GrahamcOfBorg
Copy link
Copy Markdown

GrahamcOfBorg commented Mar 8, 2018

Success on x86_64-linux (full log)

Partial log (click to expand)


*** Downloading ‘https://cache.nixos.org/nar/0p553r92nvcq8izdwna3cxhshv15qyf8kpw9cvd00dr7c2jpgqkx.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/4rg74yd7vm9jij2akz1wp7xcwxm3vajb-SDL_mixer-1.2.12’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 70768  100 70768    0     0   330k      0 --:--:-- --:--:-- --:--:--  329k

/nix/store/p26kggyw4s40cn0180i3519d7pfzlsrw-SDL-1.2.15
/nix/store/ryhabjvmpqnbyymsd9qs4957vam29dxv-SDL_image-1.2.12
/nix/store/rfy7vqvfpy6rcsgr5ah0f3kjnrrs5i5r-SDL_ttf-2.0.11
/nix/store/4rg74yd7vm9jij2akz1wp7xcwxm3vajb-SDL_mixer-1.2.12

@GrahamcOfBorg
Copy link
Copy Markdown

GrahamcOfBorg commented Mar 8, 2018

Success on aarch64-linux (full log)

Partial log (click to expand)

  /nix/store/yfaxm5a645z9cbjsz23rx0jr4k4pywax-SDL-1.2.15-dev
copying path '/nix/store/6cgcnlddj9f4ldg4zh11br508b117bfb-SDL_image-1.2.12' from 'https://cache.nixos.org'...
copying path '/nix/store/mlpqydsz13a5glcbfin1vz3qk3ihjjyy-SDL_ttf-2.0.11' from 'https://cache.nixos.org'...
copying path '/nix/store/yfaxm5a645z9cbjsz23rx0jr4k4pywax-SDL-1.2.15-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/135kyd2gki19205b2c09dl6h4s9l2xj1-smpeg-svn390' from 'https://cache.nixos.org'...
copying path '/nix/store/sa7v98ksfy4q4nwd9xvr5l8gvx5gm9dv-SDL_mixer-1.2.12' from 'https://cache.nixos.org'...
/nix/store/daijpnf7hpc6309lghxj3926vq4a08vm-SDL-1.2.15
/nix/store/6cgcnlddj9f4ldg4zh11br508b117bfb-SDL_image-1.2.12
/nix/store/mlpqydsz13a5glcbfin1vz3qk3ihjjyy-SDL_ttf-2.0.11
/nix/store/sa7v98ksfy4q4nwd9xvr5l8gvx5gm9dv-SDL_mixer-1.2.12

@GrahamcOfBorg
Copy link
Copy Markdown

GrahamcOfBorg commented Mar 8, 2018

Success on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/ikcdk6s24zccg5gdav1f3bhyig5hr6l5-SDL_mixer-1.2.12/lib/libSDL_mixer-1.2.0.dylib: fixing dylib
/nix/store/ikcdk6s24zccg5gdav1f3bhyig5hr6l5-SDL_mixer-1.2.12/lib/libSDL_mixer-1.2.0.dylib: fixing dylib
/nix/store/ikcdk6s24zccg5gdav1f3bhyig5hr6l5-SDL_mixer-1.2.12/lib/libSDL_mixer-1.2.0.dylib: fixing dylib
/nix/store/ikcdk6s24zccg5gdav1f3bhyig5hr6l5-SDL_mixer-1.2.12/lib/libSDL_mixer-1.2.0.dylib: fixing dylib
/nix/store/ikcdk6s24zccg5gdav1f3bhyig5hr6l5-SDL_mixer-1.2.12/lib/libSDL_mixer-1.2.0.dylib: fixing dylib
/nix/store/ikcdk6s24zccg5gdav1f3bhyig5hr6l5-SDL_mixer-1.2.12/lib/libSDL_mixer-1.2.0.dylib: fixing dylib
/nix/store/kclmnd47ckm9clbz1lffk1hsjhclwydh-SDL-1.2.15
/nix/store/vvpn16bak4j94vr35lf90fqbf5iywllz-SDL_image-1.2.12
/nix/store/h552r695gmb7xa6y17gqq8lcc0p3ay3p-SDL_ttf-2.0.11
/nix/store/ikcdk6s24zccg5gdav1f3bhyig5hr6l5-SDL_mixer-1.2.12

@7c6f434c 7c6f434c merged commit b61ac66 into NixOS:master Mar 8, 2018
@oxij
Copy link
Copy Markdown
Member Author

oxij commented Mar 8, 2018 via email

@oxij oxij deleted the pkgs/fix-pulseaudio-references-fix branch September 8, 2018 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oxij @7c6f434c @ryantm @GrahamcOfBorg