writeShellApplication: fix shellcheck availability check#362868
Merged
philiptaron merged 1 commit intoNixOS:masterfrom Dec 8, 2024
Merged
writeShellApplication: fix shellcheck availability check#362868philiptaron merged 1 commit intoNixOS:masterfrom
philiptaron merged 1 commit intoNixOS:masterfrom
Conversation
This fixes NixOS evaluation for native riscv64-linux
75d31e7 to
83e3724
Compare
sternenseemann
approved these changes
Dec 8, 2024
philiptaron
approved these changes
Dec 8, 2024
Member
|
I still get the error with this PR applied. |
Member
|
@RossComputerGuy Can you post the backtrace? I do remember testing this… |
Member
|
Not right now but later I can. When I was testing this, I was using |
13 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/cannot-run-docker-container-as-systemd-service-on-risc-v/59483/2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes NixOS evaluation for native riscv64-linux.
Closes: #231537
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.