Skip to content

nixos/pipewire: mention possible integration with pulseaudio#353789

Merged
Atemu merged 1 commit into
NixOS:masterfrom
doronbehar:nixos/pipewire@compositor-only
Nov 5, 2024
Merged

nixos/pipewire: mention possible integration with pulseaudio#353789
Atemu merged 1 commit into
NixOS:masterfrom
doronbehar:nixos/pipewire@compositor-only

Conversation

@doronbehar

Copy link
Copy Markdown
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@doronbehar doronbehar requested a review from K900 November 5, 2024 10:36
@github-actions github-actions Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 5, 2024
Comment thread nixos/modules/services/desktops/pipewire/pipewire.nix Outdated
@doronbehar doronbehar force-pushed the nixos/pipewire@compositor-only branch from c783fc7 to 43864d7 Compare November 5, 2024 11:11

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
message = "Using PipeWire's ALSA/PulseAudio compatibility layers requires running PipeWire as the sound server. Set `services.pipewire.audio.enable` to true, or set both `services.pipewire.pulse.enable` and `services.pipewire.alsa.enable` to false if you wish to use pipewire only for compositor.";
message = "Using PipeWire's ALSA/PulseAudio compatibility layers requires running PipeWire as the sound server. Set `services.pipewire.audio.enable` to true, or set both `services.pipewire.pulse.enable` and `services.pipewire.alsa.enable` to false if you wish to use pipewire only for video.";

Would video be a bit easier to understand here compared to compositor?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would video be a bit easier to understand here compared to compositor?

Hmm I agree that the term compositor is a bit too contextual, but video is too inaccurate IMO and a bit confusing - people might think it may only be related to video displaying programs like vlc, and not the basic functionality of the desktop environment etc. I'd prefer to be accurate and less immediately clear for inexperienced users, but I'm open to hear other suggestions.

Comment thread nixos/modules/services/desktops/pipewire/pipewire.nix Outdated
The previous assert message was inaccurate, as it didn't reflect the
assertion condition, misleading users into thinking that either
pulseaudio or pipewire should be used as a sound server.
@doronbehar doronbehar force-pushed the nixos/pipewire@compositor-only branch from 43864d7 to 2415e26 Compare November 5, 2024 16:02
@Atemu Atemu merged commit ec3d46c into NixOS:master Nov 5, 2024
@nixos-discourse

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-can-i-disable-pipewire/58274/4

@doronbehar doronbehar deleted the nixos/pipewire@compositor-only branch February 10, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants