Skip to content

rip2: init at 0.9.0#353742

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
MilesCranmer:rip2
Nov 8, 2024
Merged

rip2: init at 0.9.0#353742
Aleksanaa merged 1 commit intoNixOS:masterfrom
MilesCranmer:rip2

Conversation

@MilesCranmer
Copy link
Copy Markdown
Contributor

@MilesCranmer MilesCranmer commented Nov 5, 2024 •
edited
Loading

rip2 (https://github.com/MilesCranmer/rip2) is a safer and ergonomic alternative to rm implemented in Rust. This is the first Nixpkgs packaging of rip2. rip2 is a fork of the original rip which is now unmaintained.

rip2 is also packaged on Homebrew, Termux, AUR, and OpenSUSE. I also have flake support on the GitHub. So I would like to add a nixpkgs version for it. I will be the maintainer.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable: package tests
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Nov 5, 2024
@MilesCranmer MilesCranmer force-pushed the rip2 branch 2 times, most recently from 3a3a9b0 to 49c601a Compare November 5, 2024 01:13
@MilesCranmer MilesCranmer mentioned this pull request Nov 5, 2024
Closed
@MilesCranmer MilesCranmer force-pushed the rip2 branch 2 times, most recently from 9f981ca to 3a922c6 Compare November 5, 2024 01:27
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 5, 2024
Aleksanaa
Aleksanaa reviewed Nov 6, 2024
View reviewed changes
@MilesCranmer
Copy link
Copy Markdown
Contributor Author

MilesCranmer commented Nov 8, 2024

Not sure why the tests are attempting to download from https://github.com/MilesCranmer/rip2/archive/0.9.0.tar.gz rather than https://github.com/MilesCranmer/rip2/archive/v0.9.0.tar.gz? I assume I'm doing something really silly... Any tips @Aleksanaa?

@MilesCranmer
Copy link
Copy Markdown
Contributor Author

MilesCranmer commented Nov 8, 2024

Actually perhaps those are old tests that are simply showing up in the log persistently?

In which case, is there anything else to do or are we good to go?

@Aleksanaa
Copy link
Copy Markdown
Member

Aleksanaa commented Nov 8, 2024

Not sure why the tests are attempting to download from https://github.com/MilesCranmer/rip2/archive/0.9.0.tar.gz rather than https://github.com/MilesCranmer/rip2/archive/v0.9.0.tar.gz? I assume I'm doing something really silly... Any tips @Aleksanaa?

Why say that? Ofborg is fine, see below

Aleksanaa
Aleksanaa reviewed Nov 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, two more suggestions

@MilesCranmer
Copy link
Copy Markdown
Contributor Author

MilesCranmer commented Nov 8, 2024

Done and done

Aleksanaa
Aleksanaa reviewed Nov 8, 2024
View reviewed changes
@MilesCranmer @Aleksanaa
rip2: init at 0.9.0
9aa30e6 
Co-authored-by: Aleksana <alexander.huang.y@gmail.com>
@Aleksanaa Aleksanaa merged commit f008280 into NixOS:master Nov 8, 2024
@MilesCranmer MilesCranmer deleted the rip2 branch November 8, 2024 14:18
@MilesCranmer MilesCranmer mentioned this pull request Nov 8, 2024
Merged
@ede1998 ede1998 mentioned this pull request Nov 11, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

Assignees

No one assigned

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MilesCranmer @Aleksanaa