config.sound: Disable sound by default#35319
Closed
adisbladis wants to merge 1 commit intoNixOS:masterfrom
Closed
Conversation
8 tasks
Contributor
|
I didn't notice this PR until now. I have the competing proposal here: #35355 Technical suggestions:
(And of course I prefer the simplicity of just completely disabling sound by default and putting it in the example config, that's why #35355 .) |
6 tasks
Member
|
Hmm, after thinking about this for a while this is IMHO not a good idea. Having more of these cross module dependencies makes the whole module machinery we have in NixOS very confusing and convoluted. X11 itself is not directly bound to sound support in any way to this doesn't make a lot of sense. If people really want this, @aristidb's suggestions should be implemented though. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
In #35292 @fpletz brought up the imo very good idea to disable sound by default.
Per my proposal here: #35292 (comment) I enable sound if
services.xserver.enableistrue.This gives most users the desired effect, desktop users get working sound and server users will not get
alsaUtilsor any ALSA services.If you feel like you dont belong in either category it's simple enough to enable.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)