Skip to content

bb: fix darwin / clang#351820

Merged
rnhmjoj merged 1 commit intoNixOS:staging-nextfrom
paparodeo:bb-fix-darwin-clang
Oct 30, 2024
Merged

bb: fix darwin / clang#351820
rnhmjoj merged 1 commit intoNixOS:staging-nextfrom
paparodeo:bb-fix-darwin-clang

Conversation

@paparodeo
Copy link
Copy Markdown
Contributor

@paparodeo paparodeo commented Oct 28, 2024

  • autoreconfHook
  • add missing headers needed for function prototypes.
  • remove regparm for clang

https://hydra.nixos.org/build/273786787

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 28, 2024
@ofborg ofborg bot requested a review from rnhmjoj October 28, 2024 10:12
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 28, 2024
@paparodeo paparodeo closed this Oct 28, 2024
@paparodeo paparodeo deleted the bb-fix-darwin-clang branch October 28, 2024 16:15
@paparodeo paparodeo restored the bb-fix-darwin-clang branch October 29, 2024 02:42
@paparodeo paparodeo reopened this Oct 29, 2024
- autoreconfHook
- add missing headers needed for function prototypes.
- remove regparm for clang
@ofborg ofborg bot requested a review from rnhmjoj October 29, 2024 04:08
@ofborg ofborg bot requested a review from rnhmjoj October 29, 2024 08:41
@rnhmjoj rnhmjoj merged commit faf294a into NixOS:staging-next Oct 30, 2024
@paparodeo paparodeo deleted the bb-fix-darwin-clang branch October 30, 2024 22:01
@paparodeo paparodeo restored the bb-fix-darwin-clang branch October 30, 2024 22:01
@paparodeo paparodeo deleted the bb-fix-darwin-clang branch October 30, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants