Skip to content

treewide: More string indentation fixes#350774

Merged
piegamesde merged 1 commit intoNixOS:stagingfrom
piegamesde:string-fixes
Oct 24, 2024
Merged

treewide: More string indentation fixes#350774
piegamesde merged 1 commit intoNixOS:stagingfrom
piegamesde:string-fixes

Conversation

@piegamesde
Copy link
Copy Markdown
Member

@piegamesde piegamesde commented Oct 23, 2024

Follow-up on #350296 with the packages that cause big rebuilds and need to go through staging.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Follow-up on NixOS#350296 with the packages that cause big rebuilds and need
to go through staging.
@github-actions github-actions bot added 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: flutter Open-source UI software development kit for cross-platform applications labels Oct 23, 2024
Copy link
Copy Markdown
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 23, 2024
@ofborg ofborg bot added 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Oct 24, 2024
@piegamesde piegamesde merged commit c3d78ae into NixOS:staging Oct 24, 2024
@piegamesde piegamesde mentioned this pull request Dec 14, 2024
13 tasks
@piegamesde piegamesde mentioned this pull request Dec 23, 2024
13 tasks
@jfly jfly moved this from Todo to Approved in Nix formatting Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: flutter Open-source UI software development kit for cross-platform applications 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

4 participants