Skip to content

apulse: 0.1.10 -> 0.1.11, add pressureaudio#35076

Merged
7c6f434c merged 2 commits intoNixOS:masterfrom
oxij:pkgs/apulse
Feb 17, 2018
Merged

apulse: 0.1.10 -> 0.1.11, add pressureaudio#35076
7c6f434c merged 2 commits intoNixOS:masterfrom
oxij:pkgs/apulse

Conversation

@oxij
Copy link
Copy Markdown
Member

@oxij oxij commented Feb 17, 2018

Motivation for this change

Living without PulseAudio.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@oxij
Copy link
Copy Markdown
Member Author

oxij commented Feb 17, 2018

I tested mpv and cmus, both work fine with this and with plain ALSA disabled. firefox gets "permission denied" errors, probably because of sandboxing. More debugging needed there.
Sharing in case anyone else wants to play with this.

@oxij oxij mentioned this pull request Feb 17, 2018
Merged
8 tasks
@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 17, 2018
@7c6f434c
Copy link
Copy Markdown
Member

7c6f434c commented Feb 17, 2018

Firefox 58 is mentioned on the apulse homepage, there is an about:config option to loosen the sandbox and allow ioctl.

@oxij
Copy link
Copy Markdown
Member Author

oxij commented Feb 17, 2018

Ah, thanks!

7c6f434c
7c6f434c previously requested changes Feb 17, 2018
View reviewed changes
pkgs/misc/apulse/pressureaudio.nix Outdated
Copy link
Copy Markdown
Member

@7c6f434c 7c6f434c Feb 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either use : for empty phases and reduce verbosity here, or fix the typo: ‘‘Coping’’ → ‘‘Copying’’

pkgs/misc/apulse/pressureaudio.nix Outdated
Copy link
Copy Markdown
Member

@7c6f434c 7c6f434c Feb 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for cp -a instead of ln -s?

pkgs/misc/apulse/pressureaudio.nix Outdated
Copy link
Copy Markdown
Member

@7c6f434c 7c6f434c Feb 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove this paragraph (and the last one)? As it is, libpulseaudio packages in Nix does not build any executables, and I am not sure there are any risks in failed attempts to connect by PA client library.

@oxij
Copy link
Copy Markdown
Member Author

oxij commented Feb 17, 2018 via email

@7c6f434c 7c6f434c dismissed their stale review February 17, 2018 18:02

concerns have been addressed

@7c6f434c 7c6f434c merged commit 280d51b into NixOS:master Feb 17, 2018
@oxij oxij deleted the pkgs/apulse branch September 8, 2018 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@7c6f434c 7c6f434c 7c6f434c left review comments

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oxij @7c6f434c @GrahamcOfBorg