Skip to content

firefox: patch to fix bug 1430274 (broken ALSA output) in 58#35047

Merged
joachifm merged 1 commit intoNixOS:masterfrom
oxij:pkg/firefox-alsa-out
Feb 16, 2018
Merged

firefox: patch to fix bug 1430274 (broken ALSA output) in 58#35047
joachifm merged 1 commit intoNixOS:masterfrom
oxij:pkg/firefox-alsa-out

Conversation

@oxij
Copy link
Copy Markdown
Member

@oxij oxij commented Feb 16, 2018

Motivation for this change

A fetchpatch by @rnhmjoj that I can confirm fixes #34822.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This was referenced Feb 16, 2018
Closed
Merged
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 16, 2018
@joachifm joachifm merged commit 801291b into NixOS:master Feb 16, 2018
@oxij oxij deleted the pkg/firefox-alsa-out branch September 8, 2018 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

firefox 58: does not produce any sound

3 participants

@oxij @joachifm @GrahamcOfBorg