Skip to content

python2-modules: Add a README explaining that Python 2 is no longer supported#348583

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
efirestone:firestone/python2-readme
Oct 31, 2024
Merged

python2-modules: Add a README explaining that Python 2 is no longer supported#348583
Aleksanaa merged 1 commit intoNixOS:masterfrom
efirestone:firestone/python2-readme

Conversation

@efirestone
Copy link
Copy Markdown
Contributor

@efirestone efirestone commented Oct 14, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@efirestone
Copy link
Copy Markdown
Contributor Author

/cc @NixOS/documentation-team

@efirestone efirestone marked this pull request as ready for review October 14, 2024 17:59
@emilazy
Copy link
Copy Markdown
Member

emilazy commented Oct 14, 2024

We do support (and rely on) resholve. Other than that this seems accurate to me.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 14, 2024
@efirestone
Copy link
Copy Markdown
Contributor Author

We do support (and rely on) resholve. Other than that this seems accurate to me.

Is it worth calling that out in the readme, or is that more of a "those who need to know already know"? If we want to call it out, is there something I can link to that has more info?

@emilazy
Copy link
Copy Markdown
Member

emilazy commented Oct 14, 2024

It’s probably fine not to mention, but maybe just some weasel wording about only supporting it for internal use would do the trick?

@efirestone efirestone force-pushed the firestone/python2-readme branch from d3f14d4 to 822ac1c Compare October 16, 2024 06:30
@Aleksanaa Aleksanaa changed the title Add a README explaining that Python 2 is no longer supported python2-modules: Add a README explaining that Python 2 is no longer supported Oct 31, 2024
@Aleksanaa Aleksanaa merged commit 1499b7c into NixOS:master Oct 31, 2024
@efirestone efirestone deleted the firestone/python2-readme branch November 24, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants