Skip to content

cosmic-wallpapers: init at 0-unstable-2024-09-27#348146

Merged
jopejoe1 merged 1 commit intoNixOS:masterfrom
Pandapip1:init-cosmic-wallpapers
Oct 18, 2024
Merged

cosmic-wallpapers: init at 0-unstable-2024-09-27#348146
jopejoe1 merged 1 commit intoNixOS:masterfrom
Pandapip1:init-cosmic-wallpapers

Conversation

@Pandapip1
Copy link
Copy Markdown
Member

@Pandapip1 Pandapip1 commented Oct 12, 2024 •
edited
Loading

Copied from https://github.com/lilyinstarlight/nixos-cosmic

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This was referenced Oct 12, 2024
Open
Closed
Aleksanaa
Aleksanaa reviewed Oct 13, 2024
View reviewed changes
@Pandapip1 Pandapip1 force-pushed the init-cosmic-wallpapers branch from 6fdc38a to 9b52c5f Compare October 13, 2024 16:34
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 13, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 13, 2024
@Pandapip1 Pandapip1 requested a review from Aleksanaa October 16, 2024 07:38
@a-kenji a-kenji requested a review from jopejoe1 October 16, 2024 19:10
a-kenji
a-kenji suggested changes Oct 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@a-kenji a-kenji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits for now.

@a-kenji
Copy link
Copy Markdown
Member

a-kenji commented Oct 16, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 348146

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 6 packages built:
  • cosmic-wallpapers
  • tests.devShellTools.nixos
  • tests.testers.lycheeLinkCheck.network
  • tests.testers.nixosTest-example
  • tests.testers.runNixOSTest-example
  • tests.trivial-builders.references

@Pandapip1 Pandapip1 force-pushed the init-cosmic-wallpapers branch from 9b52c5f to b3722d7 Compare October 16, 2024 22:12
lilyinstarlight
lilyinstarlight reviewed Oct 16, 2024
View reviewed changes
@Pandapip1 Pandapip1 force-pushed the init-cosmic-wallpapers branch 3 times, most recently from ef3b1b4 to bb0c541 Compare October 17, 2024 22:08
jopejoe1
jopejoe1 previously requested changes Oct 17, 2024
View reviewed changes
@Pandapip1 Pandapip1 force-pushed the init-cosmic-wallpapers branch from bb0c541 to 489ccd8 Compare October 18, 2024 04:43
@Pandapip1 Pandapip1 requested a review from jopejoe1 October 18, 2024 04:43
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 18, 2024
@Aleksanaa Aleksanaa removed the request for review from lilyinstarlight October 18, 2024 04:44
@Pandapip1 Pandapip1 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 18, 2024
@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Oct 18, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2047

@ofborg ofborg bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 18, 2024
jopejoe1
jopejoe1 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jopejoe1 jopejoe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 348146 run on x86_64-linux 1

1 package built:
  • cosmic-wallpapers

@jopejoe1 jopejoe1 merged commit 686aecb into NixOS:master Oct 18, 2024
@Pandapip1 Pandapip1 deleted the init-cosmic-wallpapers branch October 18, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jopejoe1 jopejoe1 jopejoe1 approved these changes

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@a-kenji a-kenji Awaiting requested review from a-kenji

+1 more reviewer

@lilyinstarlight lilyinstarlight lilyinstarlight left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Pandapip1 @a-kenji @nixos-discourse @lilyinstarlight @jopejoe1 @Aleksanaa